Conversation
- Replace Jest with Vitest (via vite-plus) - Replace XO/ESLint with Oxlint - Replace Prettier with Oxfmt - Convert all done() callback tests to Promise-based - Add await to all expect().rejects/resolves assertions - Update CI workflow to use voidzero-dev/setup-vp@v1 - Add coverage reporting with v8 provider - Add vite.config.ts with test, lint, and fmt config
BREAKING CHANGE: Minimum Node.js version is now 22.12.0
Override minimatch to >=3.1.4 in pnpm-workspace.yaml to resolve 3 high-severity ReDoS vulnerabilities (GHSA-3ppc-4f35-3m26, GHSA-7r86-cg39-jmmj, GHSA-23c5-xmqv-rm74) in postcss-url's transitive dependency.
- Update engines to >=22.13.0 (pnpm@11.1.2 requires it) - Use node version '22' in CI matrix (latest 22.x) - Set run-install: false in setup-vp to use explicit install step - Add github-token to coveralls action
- Add missing @vitest/coverage-v8 devDependency for coverage reports - Add Node.js 24 to CI test matrix
Worker forks crash on Windows. Switch default pool to threads and use Vitest projects config to run cli.test.js (which needs process.chdir) in the forks pool.
Puppeteer's postinstall may not reliably download Chrome on all platforms. Add an explicit install step to ensure Chrome is available for tests on Windows + Node 24.
Instead of relying on Puppeteer's postinstall to download Chrome (which fails intermittently on Windows CI runners), use the browser-actions/setup-chrome action to install a stable Chrome and point Puppeteer to it via PUPPETEER_EXECUTABLE_PATH. PUPPETEER_SKIP_DOWNLOAD=true prevents redundant Chrome downloads.
bezoerb
added a commit
to baevm/critical
that referenced
this pull request
May 17, 2026
# Via GitHub * master: chore: bump actions (addyosmani#621) vite+ & dependency update (addyosmani#620) bump penthouse (addyosmani#617) fix: package.json & package-lock.json to reduce vulnerabilities (addyosmani#619) # Conflicts: # cli.js # package-lock.json # package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.