Fix std::format unit test#1966
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1966 +/- ##
==========================================
+ Coverage 71.61% 71.64% +0.02%
==========================================
Files 658 658
Lines 29114 29114
Branches 3169 3171 +2
==========================================
+ Hits 20851 20858 +7
+ Misses 6457 6450 -7
Partials 1806 1806 ☔ View full report in Codecov by Sentry. |
Member
Author
|
Note: I fixed the typos in the other active PR since it's a small patch. Should I cherry-pick the commit into it's own PR? |
Neverlord
force-pushed
the
issues/1963
branch
from
5a0f82e to
9343a79
Compare
Neverlord
approved these changes
Dec 1, 2024
Member
No need, I've already rebased this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1963
When building in c++23 mode with
std::formatsupport a static cast in the unit tests will fail. The main reason is that c++23 adds support for ranges to std::format, so avectorcan be formatted now. Changed the test to use another type that isn't in the std library.