Skip to content

feat: Add nooargs constructors so we work in Jakarta #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ehsavoie merged 3 commits into from
Jan 9, 2026
Merged

feat: Add nooargs constructors so we work in Jakarta #580

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ca08a8
fix: Add nooargs constructors so we work in Jakarta
kabir Jan 8, 2026
2eb6621
Make injected fields non-final
kabir Jan 9, 2026
6e1c600
Satisfy my Gemini overlord
kabir Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Satisfy my Gemini overlord
  • Loading branch information
@kabir
kabir committed Jan 9, 2026
commit 6e1c6000d78463e4b70336fadbc8fdbe58eb2cd9
2 changes: 2 additions & 0 deletions ...core/src/main/java/io/a2a/extras/queuemanager/replicated/core/ReplicatedQueueManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ public class ReplicatedQueueManager implements QueueManager {

/**
* No-args constructor for CDI proxy creation.
* CDI requires a non-private constructor to create proxies for @ApplicationScoped beans.
* All fields are initialized by the @Inject constructor during actual bean creation.
*/
Comment thread
kabir marked this conversation as resolved.
@SuppressWarnings("NullAway")
protected ReplicatedQueueManager() {
Expand Down
2 changes: 2 additions & 0 deletions server-common/src/main/java/io/a2a/server/events/InMemoryQueueManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ public class InMemoryQueueManager implements QueueManager {

/**
* No-args constructor for CDI proxy creation.
* CDI requires a non-private constructor to create proxies for @ApplicationScoped beans.
* All fields are initialized by the @Inject constructor during actual bean creation.
*/
Comment thread
kabir marked this conversation as resolved.
@SuppressWarnings("NullAway")
protected InMemoryQueueManager() {
Expand Down
3 changes: 3 additions & 0 deletions server-common/src/main/java/io/a2a/server/tasks/BasePushNotificationSender.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,11 @@ public class BasePushNotificationSender implements PushNotificationSender {
private A2AHttpClient httpClient;
private PushNotificationConfigStore configStore;


/**
* No-args constructor for CDI proxy creation.
* CDI requires a non-private constructor to create proxies for @ApplicationScoped beans.
* All fields are initialized by the @Inject constructor during actual bean creation.
*/
Comment thread
kabir marked this conversation as resolved.
@SuppressWarnings("NullAway")
protected BasePushNotificationSender() {
Expand Down
5 changes: 5 additions & 0 deletions transport/jsonrpc/src/main/java/io/a2a/transport/jsonrpc/handler/JSONRPCHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,11 @@ public class JSONRPCHandler {
private RequestHandler requestHandler;
private Executor executor;

/**
* No-args constructor for CDI proxy creation.
* CDI requires a non-private constructor to create proxies for @ApplicationScoped beans.
* All fields are initialized by the @Inject constructor during actual bean creation.
*/
@SuppressWarnings("NullAway")
protected JSONRPCHandler() {
Comment thread
kabir marked this conversation as resolved.
// For CDI proxy creation
Expand Down
5 changes: 5 additions & 0 deletions transport/rest/src/main/java/io/a2a/transport/rest/handler/RestHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,11 @@ public class RestHandler {
private RequestHandler requestHandler;
private Executor executor;

/**
* No-args constructor for CDI proxy creation.
* CDI requires a non-private constructor to create proxies for @ApplicationScoped beans.
* All fields are initialized by the @Inject constructor during actual bean creation.
*/
@SuppressWarnings("NullAway")
protected RestHandler() {
// For CDI
Expand Down