Skip to content

feat: Add nooargs constructors so we work in Jakarta #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ehsavoie merged 3 commits into from
Jan 9, 2026
Merged

feat: Add nooargs constructors so we work in Jakarta #580

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ca08a8
fix: Add nooargs constructors so we work in Jakarta
kabir Jan 8, 2026
2eb6621
Make injected fields non-final
kabir Jan 9, 2026
6e1c600
Satisfy my Gemini overlord
kabir Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: Add nooargs constructors so we work in Jakarta
  • Loading branch information
@kabir
kabir committed Jan 8, 2026
commit 4ca08a8321ded70440dfd0d8361489995ffdae5e
11 changes: 11 additions & 0 deletions ...core/src/main/java/io/a2a/extras/queuemanager/replicated/core/ReplicatedQueueManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,17 @@ public class ReplicatedQueueManager implements QueueManager {

private TaskStateProvider taskStateProvider;

/**
* No-args constructor for CDI proxy creation.
*/
Comment thread
kabir marked this conversation as resolved.
@SuppressWarnings("NullAway")
protected ReplicatedQueueManager() {
// For CDI proxy creation
this.delegate = null;
this.replicationStrategy = null;
this.taskStateProvider = null;
}
Comment thread
kabir marked this conversation as resolved.

@Inject
public ReplicatedQueueManager(ReplicationStrategy replicationStrategy, TaskStateProvider taskStateProvider) {
this.replicationStrategy = replicationStrategy;
Expand Down
10 changes: 10 additions & 0 deletions server-common/src/main/java/io/a2a/server/events/InMemoryQueueManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,16 @@ public class InMemoryQueueManager implements QueueManager {
private final EventQueueFactory factory;
private final TaskStateProvider taskStateProvider;

/**
* No-args constructor for CDI proxy creation.
*/
Comment thread
kabir marked this conversation as resolved.
@SuppressWarnings("NullAway")
protected InMemoryQueueManager() {
// For CDI proxy creation
this.factory = null;
this.taskStateProvider = null;
}
Comment thread
kabir marked this conversation as resolved.

@Inject
public InMemoryQueueManager(TaskStateProvider taskStateProvider) {
this.factory = new DefaultEventQueueFactory();
Expand Down
17 changes: 17 additions & 0 deletions server-common/src/main/java/io/a2a/server/requesthandlers/DefaultRequestHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,23 @@ public class DefaultRequestHandler implements RequestHandler {

private final Executor executor;

/**
* No-args constructor for CDI proxy creation.
* CDI requires a non-private constructor to create proxies for @ApplicationScoped beans.
* All fields are initialized by the @Inject constructor during actual bean creation.
*/
@SuppressWarnings("NullAway")
protected DefaultRequestHandler() {
// For CDI proxy creation
this.agentExecutor = null;
this.taskStore = null;
this.queueManager = null;
this.pushConfigStore = null;
this.pushSender = null;
this.requestContextBuilder = null;
this.executor = null;
}
Comment thread
kabir marked this conversation as resolved.

@Inject
public DefaultRequestHandler(AgentExecutor agentExecutor, TaskStore taskStore,
QueueManager queueManager, PushNotificationConfigStore pushConfigStore,
Expand Down
10 changes: 10 additions & 0 deletions server-common/src/main/java/io/a2a/server/tasks/BasePushNotificationSender.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,16 @@ public class BasePushNotificationSender implements PushNotificationSender {
private final A2AHttpClient httpClient;
private final PushNotificationConfigStore configStore;

/**
* No-args constructor for CDI proxy creation.
*/
Comment thread
kabir marked this conversation as resolved.
@SuppressWarnings("NullAway")
protected BasePushNotificationSender() {
// For CDI proxy creation
this.httpClient = null;
this.configStore = null;
}
Comment thread
kabir marked this conversation as resolved.

@Inject
public BasePushNotificationSender(PushNotificationConfigStore configStore) {
this.httpClient = new JdkA2AHttpClient();
Expand Down
9 changes: 9 additions & 0 deletions transport/jsonrpc/src/main/java/io/a2a/transport/jsonrpc/handler/JSONRPCHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,15 @@ public class JSONRPCHandler {
private RequestHandler requestHandler;
private final Executor executor;

@SuppressWarnings("NullAway")
protected JSONRPCHandler() {
Comment thread
kabir marked this conversation as resolved.
// For CDI proxy creation
this.agentCard = null;
this.extendedAgentCard = null;
this.requestHandler = null;
this.executor = null;
}
Comment thread
kabir marked this conversation as resolved.

@Inject
public JSONRPCHandler(@PublicAgentCard AgentCard agentCard, @Nullable @ExtendedAgentCard Instance<AgentCard> extendedAgentCard,
RequestHandler requestHandler, @Internal Executor executor) {
Expand Down