Skip to content

fix: Implement reference counting for EventQueue to prevent premature MainQueue closure #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fjuma merged 3 commits into from
Oct 14, 2025
Merged

fix: Implement reference counting for EventQueue to prevent premature MainQueue closure #333

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c2a081
fix: Implement reference counting for EventQueue to prevent premature…
kabir Oct 13, 2025
f6f7fb3
Don't generate thread dumps etc always, and readd logging
kabir Oct 13, 2025
19225aa
Remove wip comment, and printlns
kabir Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't generate thread dumps etc always, and readd logging
  • Loading branch information
@kabir
kabir committed Oct 13, 2025
commit f6f7fb330359a7046f65ae36e3817eee06ca3e4b
21 changes: 11 additions & 10 deletions .github/workflows/run-tck.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,12 +97,13 @@ jobs:
done

- name: Run TCK
id: run-tck
timeout-minutes: 5
run: |
./run_tck.py --sut-url ${{ env.SUT_JSONRPC_URL }} --category all --transports jsonrpc,grpc,rest --compliance-report report.json
working-directory: tck/a2a-tck
- name: Capture Thread Dump
if: always()
if: failure()
run: |
# Find the actual Quarkus JVM (child of Maven process), not the Maven parent
# Look for the dev.jar process which is the actual application
Expand All @@ -119,7 +120,7 @@ jobs:
ps aux | grep java || true
fi
- name: Capture Heap Dump
if: always()
if: failure()
run: |
# Find the actual Quarkus JVM (child of Maven process), not the Maven parent
QUARKUS_PID=$(pgrep -f "a2a-tck-server-dev.jar" || echo "")
Expand All @@ -145,8 +146,8 @@ jobs:
# Find and kill the Quarkus process to ensure logs are flushed
pkill -f "quarkus:dev" || true
sleep 2
- name: Verify and Upload TCK Log
if: always()
- name: Verify TCK Log
if: failure()
run: |
echo "Checking for log file..."
if [ -f tck/target/tck-test.log ]; then
Expand All @@ -158,26 +159,26 @@ jobs:
ls -la tck/target/ || echo "tck/target/ does not exist"
fi
- name: Upload TCK Log
if: always()
if: failure()
uses: actions/upload-artifact@v4
with:
name: tck-test-log-java-${{ matrix.java-version }}
path: tck/target/tck-test.log
retention-days: 7
retention-days: 2
if-no-files-found: warn
- name: Upload Thread Dump
if: always()
if: failure()
uses: actions/upload-artifact@v4
with:
name: thread-dump-java-${{ matrix.java-version }}
path: tck/target/thread-dump.txt
retention-days: 1
retention-days: 2
if-no-files-found: warn
- name: Upload Heap Dump
if: always()
if: failure()
uses: actions/upload-artifact@v4
with:
name: heap-dump-java-${{ matrix.java-version }}
path: tck/target/heap-dump.hprof.gz
retention-days: 1
retention-days: 2
if-no-files-found: warn
11 changes: 11 additions & 0 deletions tck/src/main/resources/application.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,14 @@ quarkus.grpc.server.use-separate-server=false
a2a.executor.core-pool-size=5
a2a.executor.max-pool-size=15
a2a.executor.keep-alive-seconds=60

# Enable debug logging for troubleshooting SSE streaming test timeouts
#quarkus.log.category."io.a2a.server.requesthandlers".level=DEBUG
#quarkus.log.category."io.a2a.server.events".level=DEBUG
#quarkus.log.category."io.a2a.server.tasks".level=DEBUG

# Log to file for analysis
quarkus.log.file.enable=true
quarkus.log.file.path=target/tck-test.log
quarkus.log.file.level=DEBUG
quarkus.log.console.level=INFO