Skip to content

Commit 4164b86

Browse files
committed
fix: Align Compat VertX Web usage with lastest changes in main code
1 parent 301aab8 commit 4164b86

15 files changed

Lines changed: 65 additions & 125 deletions

File tree

compat-0.3/reference/grpc/src/test/java/org/a2aproject/sdk/compat03/server/grpc/quarkus/AuthTestProfile_v0_3.java

Lines changed: 0 additions & 36 deletions
This file was deleted.

compat-0.3/reference/grpc/src/test/java/org/a2aproject/sdk/compat03/server/grpc/quarkus/QuarkusA2AGrpc_v0_3_WithAuthTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
import org.a2aproject.sdk.compat03.client.transport.grpc.GrpcTransportConfigBuilder_v0_3;
88
import org.a2aproject.sdk.compat03.client.transport.spi.interceptors.auth.AuthInterceptor_v0_3;
99
import org.a2aproject.sdk.compat03.conversion.AbstractA2AServerWithAuthTest_v0_3;
10+
import org.a2aproject.sdk.compat03.conversion.AuthTestProfile_v0_3;
1011
import org.a2aproject.sdk.compat03.spec.TransportProtocol_v0_3;
1112
import io.grpc.ManagedChannel;
1213
import io.grpc.ManagedChannelBuilder;

compat-0.3/reference/jsonrpc/src/main/java/org/a2aproject/sdk/compat03/server/apps/quarkus/A2AServerRoutes_v0_3.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ void setupRoutes(@Observes Router router) {
9999
invokeJSONRPCHandler(ctx.body().asString(), ctx);
100100
});
101101
} catch (UnauthorizedException | ForbiddenException e) {
102-
VertxSecurityHelper.handleAuthError(ctx, e);
102+
vertxSecurityHelper.handleAuthError(ctx, e);
103103
} catch (Exception e) {
104104
VertxSecurityHelper.handleGenericError(ctx);
105105
}

compat-0.3/reference/jsonrpc/src/test/java/org/a2aproject/sdk/compat03/server/apps/quarkus/QuarkusA2AJSONRPC_v0_3_WithAuthTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import org.a2aproject.sdk.compat03.client.transport.jsonrpc.JSONRPCTransportConfigBuilder_v0_3;
66
import org.a2aproject.sdk.compat03.client.transport.spi.interceptors.auth.AuthInterceptor_v0_3;
77
import org.a2aproject.sdk.compat03.conversion.AbstractA2AServerWithAuthTest_v0_3;
8+
import org.a2aproject.sdk.compat03.conversion.AuthTestProfile_v0_3;
89
import org.a2aproject.sdk.compat03.spec.TransportProtocol_v0_3;
910
import io.quarkus.test.junit.QuarkusTest;
1011
import io.quarkus.test.junit.TestProfile;

compat-0.3/reference/rest/src/main/java/org/a2aproject/sdk/compat03/server/rest/quarkus/A2AServerRoutes_v0_3.java

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ private Handler<RoutingContext> authenticated(Consumer<RoutingContext> action) {
150150
try {
151151
vertxSecurityHelper.runInRequestContext(ctx, () -> action.accept(ctx));
152152
} catch (UnauthorizedException | ForbiddenException e) {
153-
VertxSecurityHelper.handleAuthError(ctx, e);
153+
vertxSecurityHelper.handleAuthError(ctx, e);
154154
} catch (Exception e) {
155155
VertxSecurityHelper.handleGenericError(ctx);
156156
}
@@ -253,10 +253,13 @@ public void cancelTask(RoutingContext rc) {
253253

254254
private void sendResponse(RoutingContext rc, @Nullable HTTPRestResponse response) {
255255
if (response != null) {
256-
rc.response()
256+
var httpResponse = rc.response()
257257
.setStatusCode(response.getStatusCode())
258-
.putHeader(CONTENT_TYPE, response.getContentType())
259-
.end(response.getBody());
258+
.putHeader(CONTENT_TYPE, response.getContentType());
259+
260+
response.getHeaders().forEach(httpResponse::putHeader);
261+
262+
httpResponse.end(response.getBody());
260263
} else {
261264
rc.response().end();
262265
}
@@ -466,7 +469,7 @@ public void onSubscribe(Flow.Subscription subscription) {
466469
this.upstream.request(1);
467470

468471
response.closeHandler(v -> {
469-
logger.info("REST SSE connection closed by client, calling EventConsumer.cancel() to stop polling loop");
472+
logger.debug("REST SSE connection closed by client, calling EventConsumer.cancel() to stop polling loop");
470473
context.invokeEventConsumerCancelCallback();
471474
subscription.cancel();
472475
});

compat-0.3/reference/rest/src/test/java/org/a2aproject/sdk/compat03/server/rest/quarkus/AuthTestProfile_v0_3.java

Lines changed: 0 additions & 37 deletions
This file was deleted.

compat-0.3/reference/rest/src/test/java/org/a2aproject/sdk/compat03/server/rest/quarkus/QuarkusA2ARest_v0_3_WithAuthTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import org.a2aproject.sdk.compat03.client.transport.rest.RestTransportConfigBuilder_v0_3;
66
import org.a2aproject.sdk.compat03.client.transport.spi.interceptors.auth.AuthInterceptor_v0_3;
77
import org.a2aproject.sdk.compat03.conversion.AbstractA2AServerWithAuthTest_v0_3;
8+
import org.a2aproject.sdk.compat03.conversion.AuthTestProfile_v0_3;
89
import org.a2aproject.sdk.compat03.spec.TransportProtocol_v0_3;
910
import io.quarkus.test.junit.QuarkusTest;
1011
import io.quarkus.test.junit.TestProfile;

compat-0.3/reference/rest/src/test/java/org/a2aproject/sdk/compat03/server/rest/quarkus/TestIdentityProvider_v0_3.java

Lines changed: 0 additions & 29 deletions
This file was deleted.

compat-0.3/server-conversion/pom.xml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,20 @@
107107
<scope>test</scope>
108108
</dependency>
109109

110+
<!-- Quarkus Security for TestIdentityProvider_v0_3 -->
111+
<dependency>
112+
<groupId>io.quarkus</groupId>
113+
<artifactId>quarkus-security</artifactId>
114+
<scope>test</scope>
115+
</dependency>
116+
117+
<!-- Quarkus JUnit5 for AuthTestProfile_v0_3 (QuarkusTestProfile) -->
118+
<dependency>
119+
<groupId>io.quarkus</groupId>
120+
<artifactId>quarkus-junit5</artifactId>
121+
<scope>test</scope>
122+
</dependency>
123+
110124
<!-- REST-assured for test utilities -->
111125
<dependency>
112126
<groupId>io.rest-assured</groupId>

compat-0.3/reference/jsonrpc/src/test/java/org/a2aproject/sdk/compat03/server/apps/quarkus/AuthTestProfile_v0_3.java renamed to compat-0.3/server-conversion/src/test/java/org/a2aproject/sdk/compat03/conversion/AuthTestProfile_v0_3.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package org.a2aproject.sdk.compat03.server.apps.quarkus;
1+
package org.a2aproject.sdk.compat03.conversion;
22

33
import java.util.Map;
44

@@ -9,12 +9,18 @@ public class AuthTestProfile_v0_3 implements QuarkusTestProfile {
99
@Override
1010
public Map<String, String> getConfigOverrides() {
1111
return Map.ofEntries(
12-
// Disable the TestIdentityProvider - we want real authentication
12+
// Disable TestIdentityProvider auto-authentication
1313
Map.entry("test.identity.auto-auth", "false"),
1414

15+
// Disable Quarkus test security
16+
Map.entry("quarkus.test.security.auth.enabled", "false"),
17+
1518
// Enable security in AgentCard (server advertises Basic Auth support)
1619
Map.entry("test.agent.security.enabled", "true"),
1720

21+
// Enable authorization so @Authenticated is enforced (used by gRPC)
22+
Map.entry("test.authorization.enabled", "true"),
23+
1824
// Enable embedded user store
1925
Map.entry("quarkus.security.users.embedded.enabled", "true"),
2026
Map.entry("quarkus.security.users.embedded.plain-text", "true"),

0 commit comments

Comments
 (0)