Editor: Use _n() for revisions count aria-label#78382
Merged
Merged
Conversation
ramonjd
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +4 B (0%) Total Size: 7.97 MB 📦 View Changed
ℹ️ View Unchanged
|
|
Flaky tests detected in 021f17f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/26006954237
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #78381
Follow-up to #78140, which introduced a descriptive
aria-labelon the Revisions button in the Post Summary sidebar:Props @tobifjellner
Why?
The string was wrapped in
__(), so the word "revisions" cannot be pluralized for languages with more complex plural rules than English. Switching to_n()lets translators provide the correct plural form (including singular "1 revision").How?
In
packages/editor/src/components/post-last-revision/index.js, thearia-labelnow uses_n():Testing Instructions
aria-labelreadsOpen revisions screen: N revisions(or1 revisionif only one revision exists).