Support object values in Select primitive#77861
Merged
Merged
Conversation
mirka
commented
Apr 30, 2026
| { users.map( ( option ) => ( | ||
| <Select.Item | ||
| key={ option.value } | ||
| value={ option } |
Member
Author
There was a problem hiding this comment.
Passing the full item object to the Select.Item's value prop (instead of just option.value) is what makes the render function for the Select.Trigger receive a full item object.
mirka
changed the title
|
Size Change: 0 B Total Size: 7.93 MB ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 6a18eee. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/25672855028
|
mirka
added
the
[Type] Breaking Change
ciampo
reviewed
May 5, 2026
ciampo
reviewed
May 8, 2026
ciampo
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Updates the
Selectprimitive so it can be used with object item values, matching Base UI's value model more closely.Why?
Base UI Select supports object item values, but our wrapper previously typed item values as strings and default-rendered item text from the raw value. This was not a good API in hindsight, because most consumers will want to model their data with separate value/labels anyway. It also makes it impossible to receive the full item object when custom-rendering the
Trigger.How?
anyvalue typing.Select.Itemchildren to the rawvalue; item content should be provided explicitly.itemsarrays.Testing Instructions
npm run lint:js packages/ui/src/form/primitives/select.npm run test:unit packages/ui/src/form/primitives/select/test/index.test.tsx.npm run build.Design System/Components/Form/Primitives/Select.