Disable TinyMCE: Warning instead of direct redirect#77747
Merged
Conversation
tyxla
added
[Block] Classic
tyxla
force-pushed
the
update/tinymce-experiment-proxy-warning
branch
from
3c754cc to
a818bc0
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 7.82 MB ℹ️ View Unchanged
|
Member
Author
|
cc @yuliyan with whom we paired on this 😉 |
|
Flaky tests detected in d07c4c6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/25061265816
|
yuliyan
approved these changes
Apr 28, 2026
Contributor
yuliyan
left a comment
yuliyan
left a comment
There was a problem hiding this comment.
I tested the PR and it works as expected. I left one small comment. Otherwise, it looks good to me:
|
|
||
| // Warn the user that they need to reload the page with TinyMCE enabled. | ||
| wp.data.dispatch( wp.notices.store ).createWarningNotice( noticeText, { | ||
| actions: [ |
Contributor
There was a problem hiding this comment.
Let's add an id to the notice options to prevent rendering duplicate notices of the same type.
Member
Author
There was a problem hiding this comment.
Good call. This actually allows us to simplify the check later, so it would rely on ID and not on the actual string.
Addressed in 899bb5b.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Display a warning instead of directly redirecting in the Disable TinyMCE experiment.
Why?
Currently, if the "Disable TinyMCE" experiment is enabled and we detect TinyMCE usage, we redirect without question. This is a bit intrusive and actually might break stuff. One example is that on mobile, it breaks the media library (see https://github.com/WordPress/WordPress/blob/eff2ed0b2d18982c5dd439e316545d6a91b95781/wp-includes/js/media-views.js#L8417).
How?
We're displaying a warning with a link. That way, the user can click the link when they're ready, instead of being redirected without prior notice. In case there's an error and the warning was not displayed, we're forcing a redirect.
Testing Instructions
window.tinymce.asdin the console.Testing Instructions for Keyboard
Same
Screenshots or screencast
Use of AI Tools
Opus 4.7