Image: Fix non-local image ID removal undo trap#77367
Merged
Merged
Conversation
|
Size Change: +41 B (0%) Total Size: 7.75 MB 📦 View Changed
ℹ️ View Unchanged
|
|
Flaky tests detected in b72778d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/24445878784
|
Member
|
This is what I'm seeing. Very subtle! This branch Kapture.2026-04-15.at.20.29.36.mp4Trunk Kapture.2026-04-15.at.20.35.39.mp4 |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
approved these changes
Apr 15, 2026
Member
|
Makes me wish we had a selector to check the undo/redo stack. I couldn't for ages see the difference between this PR and trunk. I think because when uploading the image, the caption is selected straight away and that creates an undo layer? |
Member
Author
|
The bug is more visible if you open a saved post where this effect would apply. You select the image block -> effect kicks in -> undo level is created and can't be cleared. That's what I tried to showcase in my screencast.
Consumers shouldn't care about this. I think a good rule is to avoid using |
Member
I was thinking of myself for debugging 😄 Thanks for the fix! |
Contributor
|
Great catch, thanks for fixing this up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This is a follow-up to #77178.
PR prevents "undo trap" for the Image block when attachment is missing from the site. Similar effects should mark attribute changes as non-persistent.
Testing Instructions
idattribute is removed.Testing Instructions for Keyboard
Same.
Screenshots or screencast
CleanShot.2026-04-15.at.12.53.57.mp4