DOM: Prefer standard caretPositionFromPoint over deprecated caretRangeFromPoint#76921
Merged
Conversation
Mamaduka
added
[Type] Enhancement
|
Size Change: -1 B (0%) Total Size: 7.73 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 994239c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23786961539
|
Member
Author
|
I'm going to merge this modernization PR. All checks are passing, and it's a minor refactoring. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ObliviousHarmony
pushed a commit
that referenced
this pull request
Apr 1, 2026
…angeFromPoint` (#76921) Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
adamsilverstein
pushed a commit
that referenced
this pull request
Apr 7, 2026
…angeFromPoint` (#76921) Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Noticed while investigating #34215.
PR modenizes
caretRangeFromPointDOM helper. Changes: ThecaretPositionFromPointis baseline available and recommended over the deprecatedcaretRangeFromPoint. See: https://developer.mozilla.org/en-US/docs/Web/API/Document/caretPositionFromPointcaretRangeFromPoint()to try the standarddocument.caretPositionFromPointfirst, falling back to the deprecated WebKit-originateddocument.caretRangeFromPointfor older browsersRange | null) and function signature unchanged — no caller changes neededDocumentMaybeWithCaretPositionFromPointandCaretPositiontypedefsTesting Instructions
The writing flow e2e tests should cover this refactoring.
Use of AI Tools
Used Cluade to validate the idea, reviewed and tested manually.