Skip to content

Core Data: Fix the list of properties persisted in autosaves #76451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mamaduka merged 1 commit into from
Mar 13, 2026
Merged

Core Data: Fix the list of properties persisted in autosaves #76451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/core-data/src/actions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,9 +730,12 @@ export const saveEntityRecord =
( acc, key ) => {
// These properties are persisted in autosaves.
if (
[ 'title', 'excerpt', 'content' ].includes(
key
)
[
'title',
'excerpt',
'content',
'meta',
].includes( key )
Comment on lines +733 to +738

@Mamaduka Mamaduka Mar 12, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list to match is below. I wonder if I should extract this into a constant.

gutenberg/packages/core-data/src/actions.js

Lines 691 to 696 in f8c6fa4

const data = [
'title',
'excerpt',
'content',
'meta',
].reduce(

@ntsekouras ntsekouras Mar 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could. It seems we want these two lists to be always in sync. Although I'd expect this to rarely change, especially with the meta prop added.

@Mamaduka Mamaduka Mar 13, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the list is probably a final for now, so let's keep it as it is.

) {
acc[ key ] = newRecord[ key ];
} else if ( key === 'status' ) {
Expand Down
Loading