Skip to content

Extensible Site Editor: Make canvas previews full height #76201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeryj merged 2 commits into from
Mar 5, 2026
Merged

Extensible Site Editor: Make canvas previews full height #76201

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01686a6
Add 100vh height to extensible site editor preview canvas
jeryj Mar 5, 2026
bfa91fe
Force rerun tests
jeryj Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/lazy-editor/src/components/editor/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,12 @@ export function Editor( {
() => ( {
...editorSettings,
...settings,
styles: [
...( editorSettings.styles ?? [] ),
...( settings?.isPreviewMode
? [ { css: 'body{min-height:100vh;}' } ]
Copy link
Copy Markdown
Contributor

@youknowriad youknowriad Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is a "lazy-editor" concern. Why would the lazy-editor be full height by default? How is this solved in other places?

Copy link
Copy Markdown
Contributor

@youknowriad youknowriad Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that it's based on canvas mode, why didn't we do the same here (I guess in "boot" package)

Copy link
Copy Markdown
Contributor Author

@jeryj jeryj Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see what you mean. Looking at it now.

Copy link
Copy Markdown
Contributor Author

@jeryj jeryj Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to boot package in #76211

: [] ),
],
} ),
[ editorSettings, settings ]
);
Expand Down
Loading