FocalPointPicker: Deprecate bottom margin#73980
Merged
Merged
Conversation
mirka
requested review from
ajitbohra,
ellatrix and
fabiankaegy
as code owners
mirka
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This was referenced Dec 12, 2025
# Conflicts: # packages/components/CHANGELOG.md
|
Size Change: -222 B (-0.01%) Total Size: 2.58 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in e9e5d36. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/20239284765
|
juanfra
reviewed
Dec 15, 2025
| * ``` | ||
| */ | ||
| export function FocalPointPicker( { | ||
| __nextHasNoMarginBottom, |
Member
There was a problem hiding this comment.
Should we explicitly ignore it instead of removing? __nextHasNoMarginBottom: _,
I see we use the restProps for the <Container>
juanfra
approved these changes
Dec 15, 2025
Member
juanfra
left a comment
juanfra
left a comment
There was a problem hiding this comment.
LGTM. I left one small comment/question.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Part of #73848
Remove the deprecated
__nextHasNoMarginBottomprop fromFocalPointPicker, making the margin-free styles the permanent default.Why?
The soft deprecation was introduced in WP 6.7 and scheduled to be removed in WP 7.0. This removes the prop, completing the deprecation cycle.
How?
__nextHasNoMarginBottomprop fromFocalPointPickerand its types and docs.Testing Instructions
Smoke test the affected components in Storybook and the app.