The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mikachan <mikachan@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Size Change: 0 B

Total Size: 2.58 MB

_{compressed-size-action}

Flaky tests detected in 7c18d1c.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/20270934683
📝 Reported issues:

• [Flaky Test] Top level navigation links inherit the text color from the theme/group but do not apply to the submenu or overlay text #53977 in /test/e2e/specs/editor/blocks/navigation-colors.spec.js

I think the second run was less flaky, using networkidle, with no flaky test reports? 👀 🤞

@mikachan, have we identified the problem? Looking at failing test traces can be helpful here. Last time I checked, the editor was displaying a multi-entity save step instead of a standard one, which caused it to fail to save.

I don't mind using the networkidle, if it's the actual fix, but there's a reason we're discouraging it via ESLint checks.

Last time I checked, the editor was displaying a multi-entity save step instead of a standard one, which caused it to fail to save.

This seems to be the consistent issue each time. The editor uses the multi-entity save but I'm assuming saveSiteEditorEntities isn't running on the second save button sometimes. I'm hesitant to make any changes to this util, as this seems to be the only test that is having issues with it. Perhaps we shouldn't use this util in this test?

Maybe we could inline the locators and steps for the second save.

Looks like inlining the second save action may work, it doesn't look like it's been reported as flaky here on the last run from this PR.