Extensible Site Editor: Design improvements and page rename#73962
Conversation
e7101bb to
36f15c3
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +246 B (+0.01%) Total Size: 2.58 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 36f15c3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/20165370438
|
jasmussen
left a comment
There was a problem hiding this comment.
From an experience POV, this is a small iterative step forward, on a project that will bring a lot of important improvements to the foundations of the site editor.
However I thinj we need a different icon and name than "Home" for this, as it will be easily confused with this site editor section being a top level affordance rather than a separate section as it is now. Instead of "Home" with the house icon, you can either call it "Overview" and use a different icon, such as brush or verse (which is nicer, but is also used for the Verse block). Or you can remove the home icon. The latter would be my preference, as it matches the existing Site Editor behavior, even if it comes with the limitation of not being able to go back to the initial state; that initial state isn't that useful. Separately, as a site editor replacement, I'd expect clicking the site logo to take you to the top level of the admin. No blockers, but something to think about.
Related #70862
What?
This PR updates the extensible site editor with a few tweaks:
You can use the following url to access the page http://localhost:8888/wp-admin/admin.php?page=site-editor