Skip to content

Automated Testing: Include Windows build for GitHub Actions static checks#73923

Merged
aduth merged 2 commits into
trunkfrom
add/github-actions-static-checks-windows
Dec 11, 2025
Merged

Automated Testing: Include Windows build for GitHub Actions static checks#73923
aduth merged 2 commits into
trunkfrom
add/github-actions-static-checks-windows

Conversation

@aduth
Copy link
Copy Markdown
Member

@aduth aduth commented Dec 11, 2025

What?

Updates GitHub Actions configuration to include Windows on Node.js 20 for "Static Analysis" checks in pull requests.

Why?

There have been numerous recent issues relating to code changes that are incompatible with Windows environments:

The situation was improved slightly in #72946, where we started running builds for Windows environments on the trunk branch. However, this is too late in the process, and is easily overlooked for some time.

How?

Since previous issues largely manifest as a result of npm run build, the changes here are isolated to adding a single build check for pull requests to run the "Static checks" build pipeline for Windows + Node.js 20.

This is a minimal compromise that aims to preserve CI optimizations introduced in #72506.

Testing Instructions

Observe that the build checks for this pull request include one passing build for Windows + Node.js 20 with "Static checks".

@aduth aduth requested a review from desrosj as a code owner December 11, 2025 17:48
@aduth aduth added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Dec 11, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 11, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: aduth <aduth@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@aduth
Copy link
Copy Markdown
Member Author

aduth commented Dec 11, 2025

Seen in GitHub checks:

image

We may want to follow-up to make this "Required" at some point.

@github-actions
Copy link
Copy Markdown

Flaky tests detected in ca2d397.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/20142282135
📝 Reported issues:

@aduth aduth merged commit b91397c into trunk Dec 11, 2025
42 of 45 checks passed
@aduth aduth deleted the add/github-actions-static-checks-windows branch December 11, 2025 19:15
@github-actions github-actions Bot added this to the Gutenberg 22.4 milestone Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants