Notice: Add right margin to content only when dismissible#73905
Merged
Conversation
t-hamano
added
[Type] Enhancement
t-hamano
commented
Dec 11, 2025
Comment on lines
-8
to
-10
| .components-notice__content { | ||
| margin-right: 0; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This is the ContrastChecker component, and this style is no longer needed.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 2.58 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 68510fe. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/20151473906
|
juanfra
approved these changes
Dec 11, 2025
Member
juanfra
left a comment
juanfra
left a comment
There was a problem hiding this comment.
Thanks for the PR, looks good to me ✅
One small question, should we reconsider the margin-right when the notice is dismissible? The computed value ends up at 25px, which feels like a fairly large visual gap. It’s almost mirroring the button width. Curious if we might want to fine-tune that, in narrow contexts it can be huge.
notice-spacing.mp4
Contributor
Author
|
@juanfra Thanks for the review!
I think that margin has been there for several years, so it may not match the current design. Perhaps we can consider improving it in a follow-up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Notice content always has a margin on the right, which is redundant when there is no close button.
Testing Instructions
Smoke test on storybook.
Screenshots or screencast