Query loop should show "change design" in toolbar in contentOnly mode#73903
Merged
Conversation
tellthemachines
requested review from
ajitbohra and
fabiankaegy
as code owners
tellthemachines
added
[Type] Bug
|
Size Change: -13 B (0%) Total Size: 2.58 MB
ℹ️ View Unchanged
|
Contributor
There was a problem hiding this comment.
For the padding, it looks like for the default slot group it returns it as is, but otherwise it gets wrapped in a ToolbarGroup (I assume that's happening now because we're in the other group):
gutenberg/packages/block-editor/src/components/block-controls/slot.js
Lines 49 to 53 in 2be64e4
So, we might wind up with a double ToolbarGroup happening? I.e. here's where the query toolbar does its thing:
Could it be as simple as removing a wrapper? 🤞
I've run out of time to look further, but otherwise moving to the other group sounds good to me 👍
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 0f1eb35. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/20151551063
|
Contributor
Author
Looks like it! That worked, thanks Andy! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
When in contentOnly mode, the Query block should show the "change design" button in its toolbar if patterns are available. #73182 hid most of the toolbar slots in contentOnly mode, and inadvertently this button was hidden too.
This PR moves the button to the "other" slot that is visible when contentOnly is enabled, and which we're using for other contentOnly-allowed functionality already.
Testing Instructions
There's a tiny padding discrepancy between its current position in trunk and this PR, which seems to be due to different markup structure between slots:
Trunk:
This PR:
I'm not sure yet what the best way to address that might be.