Global Styles: Add text alignment support to elements#73854
Merged
Conversation
youknowriad
added
the
Global Styles
|
Size Change: -9 B (0%) Total Size: 2.58 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 054730d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/20130756938
|
t-hamano
approved these changes
Dec 11, 2025
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
Everything is working fine, I think we can ship this PR once we update the unit tests.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Related https://github.com/WordPress/gutenberg/pull/61717/files#r1603273968
Enables the text alignment control for elements (like text, headings, buttons, etc.) in the Global Styles UI.
Why?
Even when
typography.textAlignis set totruein theme.json, the text alignment control was not showing up in the Global Styles UI when editing elements. This was because the code explicitly disabled textAlign for all elements.How?
packages/block-editor/src/components/global-styles/hooks.jsthat was forcingtextAlign: falsefor all elementstextAlignto theROOT_BLOCK_SUPPORTSarray inpackages/blocks/src/store/private-selectors.jsso it's recognized as a valid element styleTesting Instructions