e2e: shorten visit-site-editor canvas-loader visible wait

ramonjd · ramonjd · commit 94d4596435a2 · 2026-04-28T10:13:04.000+10:00
The site-editor performance suite has been spending ~60s per `visitSiteEditor` call since #77443 because the loader element no longer becomes visible (the editor resolves inside the 100ms artificial-delay in `useIsSiteEditorLoading` before React commits the loading render). The visible-state wait then times out at 60s and the catch block recovers, costing ~10-13 min per perf workflow run. Drop the visible-state timeout to 3s. The loader either appears within a tick or it doesn't appear at all, so the long wait is just wasted wall clock when the loader is skipped.
diff --git a/packages/e2e-test-utils-playwright/src/admin/visit-site-editor.ts b/packages/e2e-test-utils-playwright/src/admin/visit-site-editor.ts
@@ -67,8 +67,12 @@ export async function visitSiteEditor(
 
 		try {
 			// Wait for the canvas loader to appear first, so that the locator that
-			// waits for the hidden state doesn't resolve prematurely.
-			await canvasLoader.waitFor( { state: 'visible', timeout: 60_000 } );
+			// waits for the hidden state doesn't resolve prematurely. The loader
+			// either renders within a tick or it is skipped entirely (when the
+			// editor finishes resolving inside the artificial-delay window in
+			// `useIsSiteEditorLoading`), so a long visible-state timeout is just
+			// wasted wall clock when the loader never shows up.
+			await canvasLoader.waitFor( { state: 'visible', timeout: 3_000 } );
 			await canvasLoader.waitFor( {
 				state: 'hidden',
 				// Bigger timeout is needed for larger entities, like the Large Post
