UI: Ensure Stack is exported from root package exports (#73928)

aduth · jsnajdr · mirka · web-flow · commit 8b0c3a5a5064 · 2025-12-12T14:24:11.000-05:00
* UI: Ensure Stack is exported from root package exports

* Remove unused references to private-apis

* Avoid path.join for glob paths

fast-glob requires forward slashes. path.join produces backslashes in Windows environment. Simple fix is to avoid path.join

* Update package-lock.json

* Use cwd option with fast-glob to avoid mixed slashes

Co-authored-by: Lena Morita &lt;lena@jaguchi.com&gt;

* Fix lint errors

---------

Co-authored-by: Lena Morita &lt;lena@jaguchi.com&gt;

Co-authored-by: aduth &lt;aduth@git.wordpress.org&gt;
Co-authored-by: jsnajdr &lt;jsnajdr@git.wordpress.org&gt;
Co-authored-by: mirka &lt;0mirka00@git.wordpress.org&gt;
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/ui/CHANGELOG.md b/packages/ui/CHANGELOG.md
@@ -0,0 +1,7 @@
+<!-- Learn how to maintain this file at https://github.com/WordPress/gutenberg/tree/HEAD/packages#maintaining-changelogs. -->
+
+## Unreleased
+
+### New Features
+
+- Add `Stack` component
diff --git a/packages/ui/package.json b/packages/ui/package.json
@@ -37,7 +37,6 @@
 	"sideEffects": false,
 	"dependencies": {
 		"@wordpress/element": "file:../element",
-		"@wordpress/private-apis": "file:../private-apis",
 		"clsx": "^2.1.1"
 	},
 	"devDependencies": {
diff --git a/packages/ui/src/index.ts b/packages/ui/src/index.ts
@@ -1 +1,2 @@
 export * from './box';
+export * from './stack';
diff --git a/packages/ui/src/lock-unlock.ts b/packages/ui/src/lock-unlock.ts
diff --git a/packages/ui/src/stack/index.ts b/packages/ui/src/stack/index.ts
@@ -1,4 +1 @@
-/**
- * Internal dependencies
- */
 export { Stack } from './stack';
diff --git a/packages/ui/src/test/index.test.ts b/packages/ui/src/test/index.test.ts
@@ -0,0 +1,22 @@
+import { join, dirname, basename } from 'node:path';
+import { readFile } from 'node:fs/promises';
+import glob from 'fast-glob';
+
+describe( 'index', () => {
+	it( 'should export something from each component', async () => {
+		// As described in the CONTRIBUTING.md file, each component should be
+		// exported from an index.ts in its implementation directory.
+		const components = await glob( '*/index.ts', {
+			cwd: join( __dirname, '..' ),
+		} );
+		const directories = components.map( ( c ) => basename( dirname( c ) ) );
+		const index = await readFile(
+			join( __dirname, '../index.ts' ),
+			'utf-8'
+		);
+
+		for ( const directory of directories ) {
+			expect( index ).toContain( `'./${ directory }'` );
+		}
+	} );
+} );
diff --git a/packages/ui/tsconfig.json b/packages/ui/tsconfig.json
@@ -4,10 +4,6 @@
 	"compilerOptions": {
 		"types": [ "node", "jest", "@testing-library/jest-dom" ]
 	},
-	"references": [
-		{ "path": "../element" },
-		{ "path": "../private-apis" },
-		{ "path": "../theme" }
-	],
+	"references": [ { "path": "../element" }, { "path": "../theme" } ],
 	"exclude": []
 }

Original file line number	Diff line number	Diff line change
`@@ -1 +1,2 @@`
`1`	`1`	`export * from './box';`
	`2`	`+export * from './stack';`
-Original file line number
+Diff line change
@@ @@ -1,4 +1 @@ @@
 -/**
 - * Internal dependencies
 - */
 export { Stack } from './stack';