This repository was archived by the owner on Nov 14, 2022. It is now read-only.
Moar entropy#34
Merged
Merged
Conversation
One less magic number!
62 possible characters (26 upper + 26 lower + 10 digits) If 16 characters long, 62^16 = 95.27 bits of entropy 20 characters, is 119.08 bits of entropy 22 gets us to over 128 bits with 130.99 bits of entropy, but to keep it chunkable in groups of four, let's bump up to 24. 24 characters gets us 142.90 bits of entropy. We have achieved [boring crypto](http://cr.yp.to/talks/2015.10.05/slides-djb-20151005-a4.pdf) Props @voodooKobra (for the advice on sufficient levels of entropy), @TimothyBJacobs (for the crypto nag)
Previously, if there was no meta value returned, it would be a string, which could cause errors.
Collaborator
Author
|
Props @sarciszewski rather -- got his GitHub handle wrong, it's not voodooKobra |
class.application-passwords.php:19:8: error - There must be exactly one blank line before the tags in a doc comment (Generic.Commenting.DocComment.SpacingBeforeTags)
Collaborator
Author
|
Just for further information on this front, Google Accounts generated application passwords seem to be only lower-case letters, so just 26^16 -- or 75.21 bits of entropy. |
Collaborator
Author
|
Just to confirm, GitHub's personal access tokens are actually 40 character hex strings. So they would have 16^40 entropy, or 160 entropy. Also p. hard to type out places. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase the entropy to over 128 bits, in order to make trying to crack application passwords sufficiently difficult.
ref: 'boring crypto'