URP quality improvements by pbbastian · Pull Request #6090 · Unity-Technologies/Graphics

pbbastian · 2021-10-21T08:09:14Z

Purpose of this PR

Various UI quality improvements

Renderer Features can now use the HelpURLAttribute to specify a documentation URL to be used in the inspector.
Added inspector documentation URLs to the SSAO, Decal, and Render Objects renderer features.
The "Add Renderer Feature" menu now supports filtering.
Removed the name input for the SSAO and Screen Space Shadows renderer features.
Fixed inspector documentation URLs for the URP asset and Universal Renderer asset.

Testing status

Tested locally

…Decal, and Render Objects

github-actions · 2021-10-21T08:09:30Z

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

SRP Core
You could run ABV on your branch before merging your PR, but it will start A LOT of jobs. Please be responsible about it and run it only when you feel the PR is ready:
/jobDefinition/.yamato%252F_abv.yml%2523all_project_ci_trunk
Be aware that any modifications to the Core package impacts everyone in the Graphics repo so please discuss the PR with your lead.

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

alex-vazquez

Some minor comments.

Nzollner

Small changes but overall LGTM

Nzollner

LGTM

alex-vazquez

Looks good, just one minor thing that I will leave up to you :)

pbbastian · 2021-11-18T09:59:38Z

🟢 001_SimpleCube_RenderPass is failing, but is also failing on master.

phi-lira · 2021-11-18T13:48:33Z

URP_Foundation on Win_DX11_playmode_mono_Linear on version trunk - broken on master 🔴

* "Add Renderer Feature" menu now uses the same menu as "Volume Overrides" * Universal Renderer help URL * Add page hash to help URL helper * Allow renderer features to use HelpURLAttribute and add it for SSAO, Decal, and Render Objects * Remove Name input for SSAO and Screen Space Shadows * Fix help URL for URP asset * Update change log * Fix change log * Remove `Attribute` suffix from attribute usage * Add docs for FilterWindow.Show * Move GetHelpURL to DocumentationUtils * Improve TryGetHelpURL interface

* URP quality improvements (#6090) * "Add Renderer Feature" menu now uses the same menu as "Volume Overrides" * Universal Renderer help URL * Add page hash to help URL helper * Allow renderer features to use HelpURLAttribute and add it for SSAO, Decal, and Render Objects * Remove Name input for SSAO and Screen Space Shadows * Fix help URL for URP asset * Update change log * Fix change log * Remove `Attribute` suffix from attribute usage * Add docs for FilterWindow.Show * Move GetHelpURL to DocumentationUtils * Improve TryGetHelpURL interface * Upgrade test materials and assets for premultiplied blend parity. (#6326) * Upgraded Runtime/Materials/*.mat files. * Foundation CommonAssets/ *.mat files upgrade. * Foundation Scenes/ .mat files upgrade. * Foundation Scenes/ .renderTexture files upgrade. * Lighting CommonAssets/ .mat upgrade. * Lighting EditMode Assets .mat files upgrade. * Lighting Scenes/ .mat files upgrade. * Lighting Scenes/ .renderTexture files upgrade. * Terrain CommonAssets/ .mat files upgrade. * Terrain Scenes/ .mat files upgrade. * PostProcessing CommonAssets/ .mat files upgrade. * PostProcessing Scenes/ .mat files upgrade. * Making intermediate render textures scale with the RenderScale setting when a camera renders to a texture (#6274) * Fix API is in the wrong state issue (#6331) * BatchRendererGroup Test Projects Automation (#6276) * update reference images * Update HDRP failing test reference images * Add HDRP Linux Vulkan test images * Rename UniversalHybridTest to BatchRendererGroup_URP * Move vulkan win ref images to None folder * Rename HDRP_HybridTests to BatchRenderGroup_HDRP * replace hybrid with BRG and add to nightly * Fix HDRP project name type * fix typo * Add .meta files of added reference images * remove playmode_xr * Update RenderBRG.cs scripts from hrnext-bugfix * Update BrgGameojbects hdrp reference images after master merge * Add vulkan to HDRP brg windows * use gpu for build, remove osx from ci * apply patch from the [Yamato] Formatting job * add BRG to nightly [skip ci] * remove the hybrid projects from repoconfig Co-authored-by: MingWai Chan <mingwai@unity3d.com> Co-authored-by: Tomas Kiniulis <tomas.kiniulis@unity3d.com> Co-authored-by: Sophia <sophia@unity3d.com> * Tweaked bloom quality options * made new settings additional * Updated docs * Improving the Bloom Test scene so that it tests Max Iterations, Downscale, Dirt Texture and Dirt Intensity * Renaming the Downscale enum to BloomDownscaleMode * Deprecating the skipIterations variable * Changelog * Changelog * Updating bloom reference image for Android GLES3 Co-authored-by: Peter Bay Bastian <pbbastian@users.noreply.github.com> Co-authored-by: Erik Hakala <59870743+eh-unity@users.noreply.github.com> Co-authored-by: Théo Penavaire <theo-pnv@users.noreply.github.com> Co-authored-by: mingwai <cinight@users.noreply.github.com> Co-authored-by: MingWai Chan <mingwai@unity3d.com> Co-authored-by: Tomas Kiniulis <tomas.kiniulis@unity3d.com> Co-authored-by: Sophia <sophia@unity3d.com> Co-authored-by: Andrem <andrem@unity3d.com>

pbbastian added 7 commits October 12, 2021 14:58

"Add Renderer Feature" menu now uses the same menu as "Volume Overrides"

85389b5

Universal Renderer help URL

9c3e52a

Add page hash to help URL helper

09e2474

Allow renderer features to use HelpURLAttribute and add it for SSAO, …

f6a88ef

…Decal, and Render Objects

Remove Name input for SSAO and Screen Space Shadows

db5dec5

Fix help URL for URP asset

a500109

Update change log

d2073aa

pbbastian requested a review from a team as a code owner October 21, 2021 08:09

pbbastian requested a review from a team October 21, 2021 08:09

alex-vazquez suggested changes Oct 21, 2021

View reviewed changes

sebastienlagarde added the universal label Nov 4, 2021

Nzollner suggested changes Nov 5, 2021

View reviewed changes

Comment thread com.unity.render-pipelines.universal/Editor/ScriptableRendererFeatureProvider.cs

Comment thread com.unity.render-pipelines.universal/Editor/ScriptableRendererFeatureProvider.cs

Comment thread com.unity.render-pipelines.universal/Runtime/UniversalRendererData.cs Outdated

pbbastian and others added 5 commits November 17, 2021 09:57

Merge branch 'master' into urp/quality-audit-peter

1cad6e1

Fix change log

d2b51c2

Remove Attribute suffix from attribute usage

edb560e

Add docs for FilterWindow.Show

f931a0a

Move GetHelpURL to DocumentationUtils

ca87ec9

Nzollner approved these changes Nov 17, 2021

View reviewed changes

alex-vazquez approved these changes Nov 17, 2021

View reviewed changes

Comment thread com.unity.render-pipelines.core/Runtime/Documentation.cs Outdated

Improve TryGetHelpURL interface

c18c3ee

phi-lira approved these changes Nov 18, 2021

View reviewed changes

phi-lira changed the base branch from master to universal/staging November 18, 2021 13:48

phi-lira merged commit 864e016 into universal/staging Nov 18, 2021

phi-lira deleted the urp/quality-audit-peter branch November 18, 2021 13:49

This was referenced Nov 18, 2021

Universal Staging #6338

Merged

Universal Staging Branch #6391

Merged

pbbastian mentioned this pull request Jan 11, 2022

[URP] Fix minor breaking API changes #6713

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

URP quality improvements#6090

URP quality improvements#6090
phi-lira merged 13 commits into
universal/stagingfrom
urp/quality-audit-peter

pbbastian commented Oct 21, 2021 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 21, 2021

Uh oh!

alex-vazquez left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Nzollner left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Nzollner left a comment

Uh oh!

alex-vazquez left a comment

Uh oh!

Uh oh!

pbbastian commented Nov 18, 2021 •

edited

Loading

Uh oh!

phi-lira commented Nov 18, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

pbbastian commented Oct 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose of this PR

Testing status

Uh oh!

github-actions Bot commented Oct 21, 2021

Uh oh!

alex-vazquez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Nzollner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Nzollner left a comment

Choose a reason for hiding this comment

Uh oh!

alex-vazquez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pbbastian commented Nov 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

phi-lira commented Nov 18, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pbbastian commented Oct 21, 2021 •

edited

Loading

pbbastian commented Nov 18, 2021 •

edited

Loading