Skip to content

[VFX][Fix] Prevent vector truncation warning/error#5542

Merged
ludovic-theobald merged 2 commits into
masterfrom
vfx/fix/hdrp-decals-matrix-truncation
Sep 9, 2021
Merged

[VFX][Fix] Prevent vector truncation warning/error#5542
ludovic-theobald merged 2 commits into
masterfrom
vfx/fix/hdrp-decals-matrix-truncation

Conversation

@ludovic-theobald

@ludovic-theobald ludovic-theobald commented Sep 7, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

[VFX][Fix] Prevent vector truncation warning/error

Checklist for PR maker

  • Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

VFX-HDRP Decal template was mixing float4x4 and float3 in a multiplication.

@github-actions

github-actions Bot commented Sep 7, 2021

Copy link
Copy Markdown

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_trunk

VFX
/.yamato%252Fall-vfx.yml%2523PR_VFX_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@ludovic-theobald ludovic-theobald mentioned this pull request Sep 7, 2021
Merged
@PaulDemeulenaere

PaulDemeulenaere commented Sep 7, 2021

Copy link
Copy Markdown

Running internal verification:
https://yamato.cds.internal.unity3d.com/jobs/339-ScriptableRenderPipelinePrivate/tree/master/.yamato%252Fvfx_hdrp-ps4-playstation4.yml%2523Build_VFX_HDRP_PS4_PlayStation4_Standalone_il2cpp_Linear_trunk/8578811/job

PaulDemeulenaere
PaulDemeulenaere approved these changes Sep 9, 2021
View reviewed changes

@PaulDemeulenaere PaulDemeulenaere left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Build VFX_HDRP is green on concerned platform
🟢

@ludovic-theobald ludovic-theobald merged commit 674376f into master Sep 9, 2021
@ludovic-theobald ludovic-theobald deleted the vfx/fix/hdrp-decals-matrix-truncation branch September 9, 2021 07:45
This was referenced Sep 16, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PaulDemeulenaere PaulDemeulenaere PaulDemeulenaere approved these changes

Assignees

No one assigned

Labels

backported-2021.2 vfx

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ludovic-theobald @PaulDemeulenaere @sebastienlagarde