Hd/fix framesettings ordering#5323
Conversation
|
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. HDRP Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
RemyUnity
left a comment
There was a problem hiding this comment.
Thank for the screenshots, I don't really see what we could test more.
LGTM 🟢
Purpose of this PR
Fix https://fogbugz.unity3d.com/f/cases/1355836/
Several PR have landed on the ProbeVolume. One of it added an hidding mechanisme. I am not fond of it as it may be more difficult now to add a new framesettings as we have some dynamically hidden. And this is also not compatible with the current UX workflow. But I understand the needs for this as it is experimental.
Then another FrameSettings was added with a dependency on the hidden one. But it was not hidden itself. So usual case, when the feature flag is disable, you have the dependant shown indented under somecing that have no relation with it (see below)

The fix here do:
Testing status
Manually tested the hidding (see screenshot above)
Comments to reviewers
@FrancescoC-unity Have your PRs been backported ?