Skip to content

Fix issue with 0-sized dispatch with extremely low resolutions#5272

Merged
sebastienlagarde merged 2 commits into
hd/bugfixfrom
HDRP/fix-zero-thread-at-very-low-res
Aug 2, 2021
Merged

Fix issue with 0-sized dispatch with extremely low resolutions#5272
sebastienlagarde merged 2 commits into
hd/bugfixfrom
HDRP/fix-zero-thread-at-very-low-res

Conversation

@FrancescoC-unity

@FrancescoC-unity FrancescoC-unity commented Aug 2, 2021

Copy link
Copy Markdown
Contributor

Fix for https://fogbugz.unity3d.com/f/cases/1354181/

The issue was due to an integer division that would round down to 0 when resolution is extremely small (not that I expect that would happen in any real project).

What did I test: downloaded repro and set the resolution to 30x30 to repro. Before it would spam an error, now it doesn't.

@FrancescoC-unity FrancescoC-unity self-assigned this Aug 2, 2021
@github-actions

github-actions Bot commented Aug 2, 2021

Copy link
Copy Markdown

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions

github-actions Bot commented Aug 2, 2021

Copy link
Copy Markdown

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@sebastienlagarde sebastienlagarde merged commit 87c680e into hd/bugfix Aug 2, 2021
@sebastienlagarde sebastienlagarde deleted the HDRP/fix-zero-thread-at-very-low-res branch August 2, 2021 15:12
@sebastienlagarde sebastienlagarde requested a review from a team August 2, 2021 15:13
@sebastienlagarde

sebastienlagarde commented Aug 2, 2021

Copy link
Copy Markdown
Contributor

Added QA for awareness but the change is small enough , test is sufficient (helping with low number of QA this week)

@sebastienlagarde sebastienlagarde mentioned this pull request Aug 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@sebastienlagarde sebastienlagarde sebastienlagarde approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@FrancescoC-unity FrancescoC-unity

Labels

backported-10.x HDRP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FrancescoC-unity @sebastienlagarde