Skip to content

Fixed the transparent cutoff not working properly in semi-transparent and color shadows (case 1340234).#4756

Merged
sebastienlagarde merged 3 commits into
hd/bugfixfrom
HDRP/fix-1340234
Jun 10, 2021
Merged

Fixed the transparent cutoff not working properly in semi-transparent and color shadows (case 1340234).#4756
sebastienlagarde merged 3 commits into
hd/bugfixfrom
HDRP/fix-1340234

Conversation

@anisunity

@anisunity anisunity commented Jun 2, 2021

Copy link
Copy Markdown
Contributor

https://fogbugz.unity3d.com/f/cases/1340234/

Testing status
Added a test to cover the issue.
DXR test are green locally.

@anisunity anisunity self-assigned this Jun 2, 2021
remi-chapelain
remi-chapelain approved these changes Jun 2, 2021
View reviewed changes

@remi-chapelain remi-chapelain left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has been quickly pair tested and new test should cover the usage without issue.

@anisunity anisunity marked this pull request as ready for review June 7, 2021 09:24
@sebastienlagarde

sebastienlagarde commented Jun 8, 2021

Copy link
Copy Markdown
Contributor

unsure if it come from the PR but after few re-run I still not get a green DXR: https://yamato-artifactviewer.prd.cds.internal.unity3d.com/e07609e1-67eb-402b-985b-6e80d915cf7d%2Flogs%2FTestProjects%2FHDRP_DXR_Tests%2Ftest-results/TestReportV1.html. I re-run once again to be sure.

@sebastienlagarde

sebastienlagarde commented Jun 8, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

unsure if it come from the PR but after few re-run I still not get a green DXR: https://yamato-artifactviewer.prd.cds.internal.unity3d.com/e07609e1-67eb-402b-985b-6e80d915cf7d%2Flogs%2FTestProjects%2FHDRP_DXR_Tests%2Ftest-results/TestReportV1.html. I re-run once again to be sure.

yup 100% failing on : HDRP_GraphicTestRunner.710_ShadowAlphaCutoff

@remi-chapelain remi-chapelain self-requested a review June 9, 2021 09:33
remi-chapelain
remi-chapelain approved these changes Jun 9, 2021
View reviewed changes

@remi-chapelain remi-chapelain left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the test screenshot,
DXR PR Job is 🟢 on yamato now.

@sebastienlagarde sebastienlagarde merged commit 2c08712 into hd/bugfix Jun 10, 2021
@sebastienlagarde sebastienlagarde deleted the HDRP/fix-1340234 branch June 10, 2021 18:01
@sebastienlagarde sebastienlagarde mentioned this pull request Jun 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@remi-chapelain remi-chapelain remi-chapelain approved these changes
+1 more reviewer
@sebastienlagarde sebastienlagarde sebastienlagarde approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@anisunity anisunity

Labels

backported-10.x dxr HDRP testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anisunity @sebastienlagarde @remi-chapelain