Fix contact shadow debug views#4720
Merged
Merged
Conversation
remi-chapelain
approved these changes
May 31, 2021
remi-chapelain
left a comment
remi-chapelain
left a comment
Contributor
There was a problem hiding this comment.
Fix looks straightforward and testing sufficient ! ✔️
Kudos for including a video of the test, very much appreciated :)
The issue only arise when resizing the view so there's no easy way to include this in automation to prevent it from regressing, which is unlikely anyway !
sebastienlagarde
approved these changes
May 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for https://fogbugz.unity3d.com/f/cases/1339327/
The load coordinates were wrong and not resilient to change of view.
What did I test: the repro scene, can see in video an exaggerated case that now works (the contact shadows are badly setup just to make sure I can see them easily)
contactShadow.mp4