[2021.2] Decal by lukaschod · Pull Request #3926 · Unity-Technologies/Graphics

lukaschod · 2021-03-19T10:00:03Z

Purpose of this PR

Adding decals to URP!!!

Architecture

Features

DecalMesh and DecalProjector.
DBuffer and ForwardEmissive.
Screen Space Forward (Basically Forward with normal reconstruction).
Screen Space GBuffer (Applies decals directly into GBuffer pass).
Angle Fade (Re-uses normal reconstruction).
Projector draw order.
Mesh bias depth/view.
Jobified data caching from transforms and draw call construction.
Burst support.
Small sub-set of ECS directly designed for decals.
All code is contained within Decal Renderer Feature. It is completely autonomous from render pipeline and nothing will be included related to decals if it is not there.
ShaderGraph only support (Enable/Disable any surface data, LOD CrossFade, AngleFade).
Draw distance.
Editor layers.
GPU instancing on/off.
Intermediate and non intermeediate rendering support (Graphics.DrawMesh/CommandBuffer.DrawMesh).
Hierarchy and non hierarchy scaling mode.
Preview rendering as plane.
Normal reconstruction support.
Error shader rendering.
Rendering on terrain.

Minor features

Special handling when there is no decal feature assigned.
Special handling when shader graph does not have angle fade enabled.
Special handling when bad materials is selected:

Testing status

Local gfx tests.
Added Decal Projector test.
Added Decal Mesh test.
Added Decal terrain test.
Added Normal Reconstruction test.
Added Normal Reconstruction Orthographic test.
Manual test https://docs.google.com/document/d/1DgUM9A1jCUcCUQ7oVNJwiheynuwEaai86iimN0zQYhY/edit.
Manual platform test https://docs.google.com/document/d/1il4mitd4BBDHDiYaYpES8oIFGDKPc56vvWX-goJXQJE/edit#.

Documentation

Files that contains any documentation/API or docs:

com.unity.render-pipelines.universal/Documentation~/TableOfContents.md
com.unity.render-pipelines.universal/Documentation~/decal-projector.md
com.unity.render-pipelines.universal/Documentation~/decal-shader.md
com.unity.render-pipelines.universal/Documentation~/renderer-feature-decal.md
com.unity.render-pipelines.universal/Documentation~/shaders-in-universalrp.md
com.unity.render-pipelines.universal/Editor/Decal/DecalProjectorEditor.Skin.cs
com.unity.render-pipelines.universal/Editor/Decal/DecalProjectorEditor.cs
com.unity.render-pipelines.universal/Editor/Decal/DecalShaderGraphGUI.cs
com.unity.render-pipelines.universal/Editor/RendererFeatures/DecalRendererFeatureEditor.cs
com.unity.render-pipelines.universal/Runtime/RendererFeatures/DisallowMultipleRendererFeature.cs
com.unity.render-pipelines.universal/Runtime/ScriptableRenderer.cs

Comments to reviewers

Main concerns of PR:

Screen Space and GBuffer does not support Decal Mesh. This is limitation of Graphics.DrawMesh as it includes all passes and there is no way to filter it without material changes).
Scriptable Renderer Feature has new virtual method OnCull (It is called by URP before culling).
Negative scale does not work with Decal Projector. By default in unity mesh renderers with negative scale has their winding inverted to account for changes, this is not part of Graphics.DrawMesh. We could workaround it with culling, but that will not work with instancing.
Currently each technique of decal requires depth as read output and shader resource. Which forces depth copy, this will be solved in future PR. (Check https://docs.google.com/document/d/1hAASKwXJiGoFDgBE7ci9lcO-qjSX9sL49oDExBmv3nQ/edit#heading=h.wo67r6cr8k6c for details)
GBuffer technique does not work on terrain detail, because details are renderer in forward only pass (Which is after whole decals).

…ction in caching.

…universal/decal

…ates on property and material change.

…hanging DecalSurfaceData to reals. Fixing screen size to be passed in all techniques correctly. Adding GI calcutation into SS and GBuffer decals.

svens-unity

Great work!

…r ShaderGraph shaders. Updating templates

…ating refernece images of test 230/245

…universal/decal

ryanhy-unity · 2021-04-30T03:41:49Z

Quest looking much better but I still see a couple issues:

Screen space project decals are not appearing at all when using deferred rendering

Vulkan screen space deferred has some errors, specifically:

the normals decals are corrupted or something.
The base decal or texture appears offset in the right eye in multiview
Finally the unlit decals are not showing up here either

ernestasKupciunas

The general quality on the mobiles looks good. Lukas has addressed all the issues that were discovered during the testing. No active ones left. Decals are rendered fine on all testing devices.
Testing Doc: https://docs.google.com/document/d/1il4mitd4BBDHDiYaYpES8oIFGDKPc56vvWX-goJXQJE/edit

Unity used for testing:
Version: 2021.2.0a15.2070
Revision: trunk af5e3dc5f881
Built: Sun, 18 Apr 2021 18:17:23 GMT

Devices under test:
VLNQA00217, Razer Phone 2, 9.0.0, Snapdragon 845 SDM845, Adreno 630
VLNQA00268, Samsung Galaxy S10+, 10.0.0, Exynos 9 9820, Mali-G76
OnePlus Nord, 10, Snapdragon 765G SM7250-AB, Adreno 620
VLNQA00126, Samsung Galaxy S5 Mini, 6.0.1, Exynos 3 Quad 3470, Mali-400 MP
Samsung Galaxy Z Fold2 5G, 10, Snapdragon 865 SM8250, Adreno 650
iPad Air4, SoC: A14, iOS: 14.0
iPhone 12Pro, SoC: A14, iOS: 14.1
AppleTV 4k 64GB, tvOS: 14.5

ryanhy-unity

I think the deferred issues seen on the Quest with Vulkan can be postponed to fix later. Otherwise looked good using Quest and Rift.

…universal/decal

…irst frame

…universal/decal

…hanges in the following days.

…ics into universal/decal

oleks-k

Edited some descriptions, the documentation is acceptable for an MVP, will make more changes in the following days.

…ics into universal/decal

…universal/decal

lukaschod added 7 commits January 21, 2021 12:54

Porting HDRP decal solution into URP as prototype

f19d850

Adding OnCull callback to ScriptableRenderer

38dd474

Adding ECS based decal system

836dd6f

Adding screen space solution. Adding decal settings. Fixing pass sele…

69f0677

…ction in caching.

Merge branch 'master' of github.com:Unity-Technologies/Graphics into …

2b81ea8

…universal/decal

Extending DissallowMultipleRendererFeature with custom title option

5674690

Adding decal gbuffer. Fixing systems job sync.

3ed4b13

github-actions Bot added Shader Graph universal labels Mar 19, 2021

lukaschod added 4 commits March 22, 2021 11:24

Fixing GBuffer Mesh to work

53370d3

Cleanup. Fixing projector to work with no material. Projector now upd…

e99a17a

…ates on property and material change.

Extending depth prepass and copy logic to account for decals

538e353

Fixing DBuffer in gamma space to use UNorm format for base texture. C…

6a7433f

…hanging DecalSurfaceData to reals. Fixing screen size to be passed in all techniques correctly. Adding GI calcutation into SS and GBuffer decals.

sebastienlagarde reviewed Mar 24, 2021

View reviewed changes

Comment thread com.unity.render-pipelines.universal/Runtime/Decal/ShaderPassDecal.hlsl

lukaschod added 12 commits March 25, 2021 17:48

Fixing fog for decals SS

1c97e80

Fixing Screen Space to work with per object data

ab0f3f8

Cleanup

0319b94

Deleting old decal system that was ported from hdrp

0e1746e

lefover

2a075f2

Fixing SS culling

302242b

Adding default decal material for urp. Adding decal projector icon

9b2b536

Adding decal error rendering when material is wrong

a2d9b9e

Removing unused namespaces

458be8a

Adding shader stripping

c6ad2d6

Cleaning up warnings

8e549e0

Cleanup

0d15811

phi-lira requested review from Verasl, eh-unity and phi-lira April 7, 2021 12:58

Moving decal code to internal

88a22be

sebastienlagarde approved these changes Apr 29, 2021

View reviewed changes

svens-unity approved these changes Apr 29, 2021

View reviewed changes

lukaschod added 4 commits April 29, 2021 17:38

Fixing Decal GBuffer shader stripping and DBuffer shader stripping fo…

ad35931

…r ShaderGraph shaders. Updating templates

Adding decal CopyDepthMaterial and DBufferClear material cleanup. Upd…

3b67c14

…ating refernece images of test 230/245

Merge branch 'master' of github.com:Unity-Technologies/Graphics into …

0d277a6

…universal/decal

Fixing dbuferclear material and not shader

a62c52c

ernestasKupciunas approved these changes Apr 30, 2021

View reviewed changes

ryanhy-unity approved these changes Apr 30, 2021

View reviewed changes

lukaschod and others added 7 commits May 3, 2021 10:14

Moving mesh recreation in case it is null to entity manager

2113c84

Merge branch 'master' of github.com:Unity-Technologies/Graphics into …

a13cb99

…universal/decal

Adding warning to decal material then screen space technique selected

efcaa6a

Disabling decals on XR. Fixing DBuffer deferred throwing warning on f…

5c9a78f

…irst frame

Merge branch 'master' of github.com:Unity-Technologies/Graphics into …

3cdaa20

…universal/decal

Edited documentation. This is acceptable for an MVP, will make more c…

b79ea6a

…hanges in the following days.

Merge branch 'universal/decal' of github.com:Unity-Technologies/Graph…

21fa1b2

…ics into universal/decal

oleks-k approved these changes May 3, 2021

View reviewed changes

lukaschod added 5 commits May 3, 2021 17:27

Changing xr compatiblity setting to prefab instead of overriden in scene

a79b53c

Merge branch 'universal/decal' of github.com:Unity-Technologies/Graph…

075120b

…ics into universal/decal

Removing error as it fails tests and updating vulkan player decal image

923aa3c

Merge branch 'master' of github.com:Unity-Technologies/Graphics into …

b046a25

…universal/decal

Adding message back as warning

b32c9af

phi-lira merged commit b468fa4 into master May 4, 2021

phi-lira deleted the universal/decal branch May 4, 2021 07:56

lukaschod mentioned this pull request May 4, 2021

[2021.2][XR] Decals #4424

Merged

ellioman mentioned this pull request Sep 15, 2021

[2021.1] Fix depth logic in renderer (Case 1364121) #5667

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[2021.2] Decal#3926

[2021.2] Decal#3926
phi-lira merged 115 commits into
masterfrom
universal/decal

lukaschod commented Mar 19, 2021 •

edited

Loading

Uh oh!

Uh oh!

svens-unity left a comment

Uh oh!

ryanhy-unity commented Apr 30, 2021

Uh oh!

ernestasKupciunas left a comment

Uh oh!

ryanhy-unity left a comment

Uh oh!

oleks-k left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants

Uh oh!

Conversation

lukaschod commented Mar 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose of this PR

Architecture

Features

Minor features

JIRA

Demo Project

Technical Design Document

Testing status

Documentation

Comments to reviewers

Uh oh!

Uh oh!

svens-unity left a comment

Choose a reason for hiding this comment

Uh oh!

ryanhy-unity commented Apr 30, 2021

Uh oh!

ernestasKupciunas left a comment

Choose a reason for hiding this comment

Uh oh!

ryanhy-unity left a comment

Choose a reason for hiding this comment

Uh oh!

oleks-k left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants

lukaschod commented Mar 19, 2021 •

edited

Loading