[HDRP] Make Decal shader compatible with SRP batcher#3806
Merged
Conversation
Contributor
Author
|
No need for QA on this PR |
arnaudcarre
approved these changes
Mar 8, 2021
sebastienlagarde
added a commit
that referenced
this pull request
Mar 8, 2021
* Fix SRP batcher with decal * Update CHANGELOG.md * Update CHANGELOG.md
sebastienlagarde
added
backported-10.x
backported-2021.1
and removed
needs-backport-10.x
needs-backport-2021.1
labels
sebastienlagarde
added a commit
that referenced
this pull request
Mar 9, 2021
* Fix SRP batcher with decal * Update CHANGELOG.md * Update CHANGELOG.md
AndrewSaraevUnity
pushed a commit
that referenced
this pull request
Apr 29, 2021
* Fix SRP batcher with decal * Update CHANGELOG.md * Update CHANGELOG.md (cherry picked from commit 5a88bb8)
AndrewSaraevUnity
added a commit
that referenced
this pull request
May 4, 2021
* [HDRP] Make Decal shader compatible with SRP batcher (#3806) * Fix SRP batcher with decal * Update CHANGELOG.md * Update CHANGELOG.md (cherry picked from commit 5a88bb8) * Added DOTS_INSTANCING_ON variants to the "HDRP/Decal" shader to support mesh decals using it in the Hybrid Renderer. (#4284) (cherry picked from commit fa2ff6e) * [2020.2] [10.x.x] [Bugfix 1296776] Enforce SRP Batcher and Hybrid renderer compatibility by always using a consolidated property list (#3577) * Make all passes in a subshader use the same HLSL proeprty declarations * Adding changelog * Better fix for Targets accessing the current blocks (cherry picked from commit 26a1096) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> Co-authored-by: Chris Tchou <ctchou@unity3d.com>
pastasfuture
pushed a commit
that referenced
this pull request
Aug 20, 2021
* [HDRP] Make Decal shader compatible with SRP batcher (#3806) * Fix SRP batcher with decal * Update CHANGELOG.md * Update CHANGELOG.md (cherry picked from commit 5a88bb8) * Added DOTS_INSTANCING_ON variants to the "HDRP/Decal" shader to support mesh decals using it in the Hybrid Renderer. (#4284) (cherry picked from commit fa2ff6e) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
pastasfuture
pushed a commit
that referenced
this pull request
Sep 15, 2021
* [HDRP] Make Decal shader compatible with SRP batcher (#3806) * Fix SRP batcher with decal * Update CHANGELOG.md * Update CHANGELOG.md (cherry picked from commit 5a88bb8) * Added DOTS_INSTANCING_ON variants to the "HDRP/Decal" shader to support mesh decals using it in the Hybrid Renderer. (#4284) (cherry picked from commit fa2ff6e) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
mohammad22
pushed a commit
that referenced
this pull request
Mar 2, 2022
* [HDRP] Make Decal shader compatible with SRP batcher (#3806) * Fix SRP batcher with decal * Update CHANGELOG.md * Update CHANGELOG.md (cherry picked from commit 5a88bb8) * Added DOTS_INSTANCING_ON variants to the "HDRP/Decal" shader to support mesh decals using it in the Hybrid Renderer. (#4284) (cherry picked from commit fa2ff6e) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Testing status
Tested that the shader is compatible with SRP batcher, checked the both shader graph and regular shader work with Mesh decal.
Comments to reviewers
Notes for the reviewers you have assigned.