Increase UniversalGraphicsTest 145_ManyAdditionalLightShadowsTypes threshold to pass on local machines#2815
Merged
Conversation
…verage Correctness Threshold to ensure it passes when executed locally
Wilfrid-Unity
added
ready-to-merge
|
It appears that you made a non-draft PR! |
ellioman
approved these changes
Dec 2, 2020
Contributor
|
This PR only increases the threshold in one scene which has already passed ABV, so running ABV again is unnecessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
#1616 introduced automated Graphics Test https://github.com/Unity-Technologies/Graphics/blob/master/TestProjects/UniversalGraphicsTest/Assets/Scenes/145_ManyAdditionalLightShadowTypes.unity
While the newly added test passes within Unity's automatic testing pipeline Yamato, it fails when executed locally from the UnityEditor (Window/General/TestRunner/PlayMode).
@ellioman reported the issue and suggested an Average Correctness Threshold value that passes on local OXS machine.
Further increasing this value also makes the test pass on other local Windows machines, hence the currently proposed value: 0.0011
Testing status
The test was confirmed to pass on local machines with this increased value.