HDRP - Fix XR shadows culling (#2263)

fabien-unity · sebastienlagarde · commit d880ff4d5681 · 2020-10-30T01:56:42.000+01:00
diff --git a/com.unity.render-pipelines.high-definition/CHANGELOG.md b/com.unity.render-pipelines.high-definition/CHANGELOG.md
@@ -66,6 +66,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Fixed issue with lookdev shadows looking wrong upon exiting playmode. 
 - Fixed temporary Editor freeze when selecting AOV output in graphics compositor (case 1288744).
 - Fixed normal flip with double sided materials.
+- Fixed XR shadows culling
 
 ### Changed
 - Combined occlusion meshes into one to reduce draw calls and state changes with XR single-pass.
diff --git a/com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.cs b/com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.cs
@@ -3256,6 +3256,10 @@ out ScriptableCullingParameters cullingParams
             if (hdCamera.xr.enabled)
             {
                 cullingParams = hdCamera.xr.cullingParams;
+
+                // Sync the FOV on the camera to match the projection from the XR device in order to cull shadows accurately
+                if (!camera.usePhysicalProperties)
+                    camera.fieldOfView = Mathf.Rad2Deg * Mathf.Atan(1.0f / cullingParams.stereoProjectionMatrix.m11) * 2.0f;
             }
             else
             {

Original file line number	Diff line number	Diff line change
`@@ -3256,6 +3256,10 @@ out ScriptableCullingParameters cullingParams`
`3256`	`3256`	`if (hdCamera.xr.enabled)`
`3257`	`3257`	`{`
`3258`	`3258`	`cullingParams = hdCamera.xr.cullingParams;`
	`3259`	`+`
	`3260`	`+ // Sync the FOV on the camera to match the projection from the XR device in order to cull shadows accurately`
	`3261`	`+ if (!camera.usePhysicalProperties)`
	`3262`	`+ camera.fieldOfView = Mathf.Rad2Deg * Mathf.Atan(1.0f / cullingParams.stereoProjectionMatrix.m11) * 2.0f;`
`3259`	`3263`	`}`
`3260`	`3264`	`else`
`3261`	`3265`	`{`