Fix update order in Graphics Compositor causing jumpy camera updates (#5235)

pmavridis · web-flow · commit 9bf35af05bda · 2021-07-28T12:58:34.000+02:00
diff --git a/com.unity.render-pipelines.high-definition/CHANGELOG.md b/com.unity.render-pipelines.high-definition/CHANGELOG.md
@@ -323,6 +323,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Fixed a null ref exception when adding a new environment to the Look Dev library.
 - Fixed a nullref in volume system after deleting a volume object (case 1348374).
 - Fixed the APV UI loosing focus when the helpbox about baking appears in the probe volume.
+- Fixed update order in Graphics Compositor causing jumpy camera updates (case 1345566).
 
 ### Changed
 - Changed Window/Render Pipeline/HD Render Pipeline Wizard to Window/Rendering/HDRP Wizard
diff --git a/com.unity.render-pipelines.high-definition/Runtime/Compositor/CompositionManager.cs b/com.unity.render-pipelines.high-definition/Runtime/Compositor/CompositionManager.cs
@@ -500,8 +500,8 @@ public void UpdateLayerSetup()
 
         static HDRenderPipelineGlobalSettings m_globalSettings;
 
-        // Update is called once per frame
-        void Update()
+        // LateUpdate is called once per frame
+        void LateUpdate()
         {
             // TODO: move all validation calls to onValidate. Before doing it, this needs some extra testing to ensure nothing breaks
             if (enableOutput == false || ValidatePipeline() == false || ValidateAndFixRuntime() == false || RuntimeCheck() == false)

Original file line number	Diff line number	Diff line change
`@@ -500,8 +500,8 @@ public void UpdateLayerSetup()`
`500`	`500`
`501`	`501`	`static HDRenderPipelineGlobalSettings m_globalSettings;`
`502`	`502`
`503`		`- // Update is called once per frame`
`504`		`- void Update()`
	`503`	`+ // LateUpdate is called once per frame`
	`504`	`+ void LateUpdate()`
`505`	`505`	`{`
`506`	`506`	`// TODO: move all validation calls to onValidate. Before doing it, this needs some extra testing to ensure nothing breaks`
`507`	`507`	`if (enableOutput == false \|\| ValidatePipeline() == false \|\| ValidateAndFixRuntime() == false \|\| RuntimeCheck() == false)`