Recompute FOV when generating PixelCoord To WorldSpace View Direction Matrix #865

FrancescoC-unity · sebastienlagarde · commit 93e565c4363b · 2020-08-03T23:29:29.000+02:00
diff --git a/com.unity.render-pipelines.high-definition/CHANGELOG.md b/com.unity.render-pipelines.high-definition/CHANGELOG.md
@@ -20,6 +20,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Fixed wrong order of post process frame settings.
 - Fixed warning in HDAdditionalLightData OnValidate (cases 1250864, 1244578)
 - Fixed issue with blue line in prefabs for volume mode.
+- Fix issue that caused sky to incorrectly render when using a custom projection matrix.
 
 ## [7.4.1] - 2020-06-03
 
diff --git a/com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Camera/HDCamera.cs b/com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Camera/HDCamera.cs
@@ -1213,6 +1213,10 @@ Matrix4x4 ComputePixelCoordToWorldSpaceViewDirectionMatrix(ViewConstants viewCon
             }
 
             float verticalFoV = camera.GetGateFittedFieldOfView() * Mathf.Deg2Rad;
+            if (!camera.usePhysicalProperties)
+            {
+                verticalFoV = Mathf.Atan(-1.0f / viewConstants.projMatrix[1, 1]) * 2;
+            }
             Vector2 lensShift = camera.GetGateFittedLensShift();
 
             return HDUtils.ComputePixelCoordToWorldSpaceViewDirectionMatrix(verticalFoV, lensShift, resolution, viewConstants.viewMatrix, false, aspect);

Original file line number	Diff line number	Diff line change
`@@ -1213,6 +1213,10 @@ Matrix4x4 ComputePixelCoordToWorldSpaceViewDirectionMatrix(ViewConstants viewCon`
`1213`	`1213`	`}`
`1214`	`1214`
`1215`	`1215`	`float verticalFoV = camera.GetGateFittedFieldOfView() * Mathf.Deg2Rad;`
	`1216`	`+ if (!camera.usePhysicalProperties)`
	`1217`	`+ {`
	`1218`	`+ verticalFoV = Mathf.Atan(-1.0f / viewConstants.projMatrix[1, 1]) * 2;`
	`1219`	`+ }`
`1216`	`1220`	`Vector2 lensShift = camera.GetGateFittedLensShift();`
`1217`	`1221`
`1218`	`1222`	`return HDUtils.ComputePixelCoordToWorldSpaceViewDirectionMatrix(verticalFoV, lensShift, resolution, viewConstants.viewMatrix, false, aspect);`