Skip to content

Fix SyliusUiBundle compiler passes priority#18979

Closed
kira0269 wants to merge 1 commit into
Sylius:2.1from
kira0269:kira0269-fix-18978
Closed

Fix SyliusUiBundle compiler passes priority#18979
kira0269 wants to merge 1 commit into
Sylius:2.1from
kira0269:kira0269-fix-18978

Conversation

@kira0269

@kira0269 kira0269 commented Apr 17, 2026

Copy link
Copy Markdown
Contributor
Q A
Branch? 2.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #18978
License MIT

@kira0269 kira0269 requested review from a team as code owners April 17, 2026 09:12
@coderabbitai

coderabbitai Bot commented Apr 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d3a3161a-be0f-4049-a2e3-5424afd338a9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@crydotsnake crydotsnake added the Bug Confirmed bugs or bugfixes. label Apr 17, 2026
TheMilek
TheMilek approved these changes Apr 21, 2026
View reviewed changes

@TheMilek TheMilek left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!

Thank you for the fix
I’d love to merge it, but could you please change the base branch to 2.2? 😄
2.1 is no more supported

Also, please add a short note to the 2.2 upgrade file, you can look for reference here how to add it for a patch

Please mention that this priority has changed since patch version 2.2.6.

Feel free to ask if you need any help with the rebase 🍻

@tomkalon tomkalon mentioned this pull request Jun 15, 2026
Merged
TheMilek added a commit that referenced this pull request Jun 18, 2026
@TheMilek
[2.2] Fix SyliusUiBundle compiler passes priority (#19057)
c070c1a 
| Q               | A
|-----------------|-----
| Branch?         |2.2
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | fixes #18978
| License         | MIT

#18979
@TheMilek

TheMilek commented Jun 18, 2026

Copy link
Copy Markdown
Member

Closing as it has been rebased and merged in #19057 🎉

@TheMilek TheMilek closed this Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Prometee Prometee Prometee approved these changes
@crydotsnake crydotsnake crydotsnake approved these changes
@TheMilek TheMilek TheMilek approved these changes

Assignees

No one assigned

Labels

Bug Confirmed bugs or bugfixes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kira0269 @TheMilek @Prometee @crydotsnake