Build sfml-main with position-independent code#2397
Merged
Conversation
Zombieschannel
approved these changes
Feb 6, 2023
Zombieschannel
left a comment
Zombieschannel
left a comment
Contributor
There was a problem hiding this comment.
Can confirm that this line fixed the issue. Android Studio does not throw out errors anymore.
MarioLiebisch
approved these changes
Feb 7, 2023
kimci86
reviewed
Feb 7, 2023
ChrisThrasher
force-pushed
the
fPIC-sfml-main
branch
from
3ad75f2 to
0ee69e4
Compare
ChrisThrasher
force-pushed
the
fPIC-sfml-main
branch
from
0ee69e4 to
4316951
Compare
kimci86
approved these changes
Feb 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #2393
This fixes an Android build problem since linking a static library into a shared library is prone to cause issues with that static library not using position independent code but those who use the shared library require position independent code.