Fix incorrect cast in Cursor::loadFromPixels Unix implementation#2073
Merged
Conversation
ChrisThrasher
approved these changes
Apr 12, 2022
ChrisThrasher
left a comment
ChrisThrasher
left a comment
Member
There was a problem hiding this comment.
Thanks for fixing the subtle formatting mistake too. Now it's easier to see what's going on.
eXpl0it3r
approved these changes
Apr 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2066
A cast was added in e0f2356 as part of PR #1846 to avoid a warning about sign conversion, but to Uint8 which is too small for a pixel in the target ARGB format.
Tasks
How to test this PR?
Running the example program provided in #2066 on a Unix platform.