Fix font pages not being created with the desired smoothness#2072
Merged
Conversation
5 tasks
eXpl0it3r
approved these changes
Apr 19, 2022
Bromeon
reviewed
Apr 19, 2022
kimci86
force-pushed
the
bugfix/font_smooth
branch
from
861f838 to
12b461d
Compare
kimci86
force-pushed
the
bugfix/font_smooth
branch
from
12b461d to
0a251d1
Compare
Member
|
Thank you for backporting this to 2.6! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is an alternative solution for the issue described in #2064
As
try_emplaceis not available with C++03, extraPagecopies occur, but at most once per character size and per font.Besides,
Pagenot having a default constructor anymore implies it is not possible to useoperator[]onm_pages, which is a good thing to force that the desired smoothness is always used to initialize new glyph pages.For reference, smoothing for fonts was first added in #1690.
Tasks
How to test this PR?
An example is provided in the original PR #2064