Skip to content

Fix Swift package manager#150

Merged
sunshinejr merged 2 commits into
masterfrom
fix/spm
Sep 13, 2019
Merged

Fix Swift package manager#150
sunshinejr merged 2 commits into
masterfrom
fix/spm

Conversation

@rynecheow

@rynecheow rynecheow commented Jun 11, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@rxswiftcommunity

rxswiftcommunity Bot commented Jun 11, 2019

Copy link
Copy Markdown
Warnings
⚠️

It looks like code was changed without adding anything to the Changelog. If this is a trivial PR that doesn't need a changelog, add #trivial to the PR title or body.

Generated by 🚫 dangerJS

@svyatogor

svyatogor commented Sep 4, 2019

Copy link
Copy Markdown

Please merge it.

@freak4pc

freak4pc commented Sep 4, 2019

Copy link
Copy Markdown
Member

Sorry for the delay in getting to this. @rynecheow can you please add a swift test stage to .circleci/config.yml (CI) ?

@rynecheow

rynecheow commented Sep 12, 2019

Copy link
Copy Markdown
Contributor Author

OHHTTPStubs dependency is unavailable to be resolved from SPM
AliSoftware/OHHTTPStubs#314

Unable to run tests even if this stage is added.

@sunshinejr

sunshinejr commented Sep 12, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

@rynecheow ah yeah correct. I think it's fine without the swift test step, but maybe we could try to setup swift build step to make sure it builds correctly?

@sunshinejr

sunshinejr commented Sep 12, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

interesting, build failed - do you know what might be the reason for the failed unit test @rynecheow?

@rynecheow

rynecheow commented Sep 13, 2019

Copy link
Copy Markdown
Contributor Author

@sunshinejr I am not sure - it seems intermittent. Once re-run it works.

@sunshinejr

sunshinejr commented Sep 13, 2019

Copy link
Copy Markdown
Member

@rynecheow ah alright. Then it seems good to go! 🚀 @freak4pc I'm gonna merge this one but in case you have additional comments we can of course get back to it asap.

also @rynecheow would you please make a new release with SPM support? 🙏

@sunshinejr sunshinejr merged commit d85e2f0 into master Sep 13, 2019
@sunshinejr sunshinejr deleted the fix/spm branch September 13, 2019 09:40
@sunshinejr sunshinejr mentioned this pull request Oct 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rynecheow @svyatogor @freak4pc @sunshinejr