Skip to content

[FIX] numerical errors in ot.gmm #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rflamary merged 11 commits into from
Nov 19, 2024
Merged

[FIX] numerical errors in ot.gmm #690

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
660e8f6
fixed numerical errors in density computations
Nov 16, 2024
444d460
lint
Nov 16, 2024
ff80102
hotfix
Nov 16, 2024
c0da656
cholesky not useful anymore
Nov 16, 2024
b955eb6
Merge branch 'master' into master
rflamary Nov 18, 2024
5ba0235
Merge branch 'master' into master
rflamary Nov 18, 2024
0a602be
vectorization
Nov 18, 2024
b48e450
Merge remote-tracking branch 'origin/master'
Nov 18, 2024
baefad2
backend tests for slogdet
Nov 18, 2024
74dbecf
update releases.md
Nov 18, 2024
0145e42
added contribution
Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cholesky not useful anymore
  • Loading branch information
Samuel Boïté committed Nov 16, 2024
commit c0da656961416911c8d7e3d07b5f94a2c8ea1fef
23 changes: 0 additions & 23 deletions ot/backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1081,14 +1081,6 @@ def slogdet(self, a):
"""
raise NotImplementedError()

def cholesky(self, a):
r"""
Cholesky decomposition.

See: https://numpy.org/doc/stable/reference/generated/numpy.linalg.cholesky.html
"""
raise NotImplementedError()


class NumpyBackend(Backend):
"""
Expand Down Expand Up @@ -1452,9 +1444,6 @@ def det(self, a):
def slogdet(self, a):
return np.linalg.slogdet(a)

def cholesky(self, x):
return np.linalg.cholesky(x)


_register_backend_implementation(NumpyBackend)

Expand Down Expand Up @@ -1851,9 +1840,6 @@ def det(self, x):
def slogdet(self, a):
return jnp.linalg.slogdet(a)

def cholesky(self, x):
return jnp.linalg.cholesky(x)


if jax:
# Only register jax backend if it is installed
Expand Down Expand Up @@ -2390,9 +2376,6 @@ def det(self, x):
def slogdet(self, a):
return torch.linalg.slogdet(a)

def cholesky(self, x):
return torch.linalg.cholesky(x)


if torch:
# Only register torch backend if it is installed
Expand Down Expand Up @@ -2804,9 +2787,6 @@ def det(self, x):
def slogdet(self, a):
return cp.linalg.slogdet(a)

def cholesky(self, x):
return cp.linalg.cholesky(x)


if cp:
# Only register cp backend if it is installed
Expand Down Expand Up @@ -3248,9 +3228,6 @@ def det(self, x):
def slogdet(self, a):
return tf.linalg.slogdet(a)

def cholesky(self, x):
return tf.linalg.cholesky(x)


if tf:
# Only register tensorflow backend if it is installed
Expand Down