Skip to content

[MRG] pre-commit with ruff,codespell,yamlint #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rflamary merged 12 commits into from
Oct 31, 2024
Merged

[MRG] pre-commit with ruff,codespell,yamlint #681

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
aaa711b
add file and lint
rflamary Oct 30, 2024
8bc7e15
add ignore words
rflamary Oct 30, 2024
3cfa1c8
update tests
rflamary Oct 30, 2024
ce6d2ea
codespell commit
rflamary Oct 30, 2024
108f9c8
test should pass
rflamary Oct 30, 2024
7f59a68
fix demo flow
rflamary Oct 30, 2024
301d189
upate release file and documentaion for conribution
rflamary Oct 30, 2024
8f7e6d1
try to fix doctests
rflamary Oct 30, 2024
a3d16ca
fix tests
rflamary Oct 30, 2024
dee2cf1
remove tets on 3.8
rflamary Oct 30, 2024
16766fa
try other mlegacy option
rflamary Oct 31, 2024
3ecba65
test correctly
rflamary Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test should pass
  • Loading branch information
@rflamary
rflamary committed Oct 30, 2024
commit 108f9c89e60309ee30e9493776748cbaaddc6793
7 changes: 6 additions & 1 deletion ot/backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1890,7 +1890,12 @@ def _to_numpy(self, a):
return a.cpu().detach().numpy()

def _from_numpy(self, a, type_as=None):
if isinstance(a, float) or isinstance(a, int):
if (
isinstance(a, float)
or isinstance(a, int)
or isinstance(a, np.float32)
or isinstance(a, np.float64)
):
a = np.array(a)
if type_as is None:
return torch.from_numpy(a)
Expand Down
4 changes: 2 additions & 2 deletions test/gromov/test_lowrank.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ def test__flat_product_operator():
X = np.reshape(1.0 * np.arange(2 * n), (n, d))
A1, A2 = ot.lowrank.compute_lr_sqeuclidean_matrix(X, X, rescale_cost=False)

A1_ = ot.gromov._flat_product_operator(A1)
A2_ = ot.gromov._flat_product_operator(A2)
A1_ = ot.gromov._lowrank._flat_product_operator(A1)
A2_ = ot.gromov._lowrank._flat_product_operator(A2)
cost = ot.dist(X, X)

# test value
Expand Down