Correct documentation for support barycenter#201
Merged
Conversation
Collaborator
|
hello @AdrienCorenflos This is the output of the doc for your PR: |
Contributor
Author
|
Looks good doesn't it?
https://317-71472695-gh.circle-artifacts.com/0/dev/gen_modules/ot.lp.html#ot.lp.free_support_barycenter
Adrien
Le mer. 15 juil. 2020 à 10:18, Rémi Flamary <notifications@github.com> a
écrit :
… hello @AdrienCorenflos <https://github.com/AdrienCorenflos>
This is the output of the doc for your PR:
https://317-71472695-gh.circle-artifacts.com/0/dev/index.html
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#201 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEYGFZYRJRVJBGE6HYP2XUTR3VJ5RANCNFSM4OZQ7CPQ>
.
|
rflamary
reviewed
Jul 15, 2020
| - we do not optimize over the weights | ||
| - we do not do line search for the locations updates, we use i.e. theta = 1 in [1] (Algorithm 2). This can be seen as a discrete implementation of the fixed-point algorithm of [2] proposed in the continuous setting. | ||
|
|
||
| Formally we solve the following problem: |
Collaborator
There was a problem hiding this comment.
Could you please put the optimization problem after the first sentence and before the discussion on the algorithm?
Also the itemize in the discussion does not work (it needs an empty line maybe)
Contributor
Author
|
Actually I'm gonna deleter this if it's ok:
"The function solves the Wasserstein barycenter problem when the barycenter
measure is constrained to be supported on k atoms"
It's redundant with the first sentence.
Le mer. 15 juil. 2020 à 16:01, Rémi Flamary <notifications@github.com> a
écrit :
@rflamary commented on this pull request.
________________________________
In ot/lp/__init__.py:
> @@ -443,18 +443,30 @@ def free_support_barycenter(measures_locations,
measures_weights, X_init, b=None
- we do not optimize over the weights
- we do not do line search for the locations updates, we use i.e.
theta = 1 in [1] (Algorithm 2). This can be seen as a discrete
implementation of the fixed-point algorithm of [2] proposed in the
continuous setting.
+ Formally we solve the following problem:
Could you please put the optimization problem after the first sentence
and before the discussion on the algorithm?
Also the itemize in the discussion does not work (it needs an empty line
maybe)
…
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Collaborator
|
Yes you can remove the repetition. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Motivation and context / Related issue
#200
How has this been tested (if it applies)
I can't render the doc locally so not tested
Checklist