Replace Adjustment and Effects menu icons with GTK icons#2102
Conversation
Updated attribution formatting and added GIMP icons source.
There was a problem hiding this comment.
And this one is used for the Feather Object effect
There was a problem hiding this comment.
I see yeah, we can merge them for now and make sure I include two new icons for Feather Object and Brightness/Contrast in the next PR, as well as the icon reference in the code.
There was a problem hiding this comment.
So sorry for the delay, how does it look now? It took me a very long time to find where the effect names were declared and didn't realize some weren't even declared (this is my first time contributing code on this project, sorry for my messy commit pattern)
There was a problem hiding this comment.
This one is used for Brightness/Contrast
There was a problem hiding this comment.
This one's coincidentally fine, but I'd prefer using GNOME's sun symbolic for brightness and most of all, avoid icon use overlap at all costs.
|
Phew, so sorry for my messy commits, I'm still learning! I added all the new icons in a new |
|
I can do some debugging of this later, but there were some issues with icons either not loading, or not being re-colored, when I did a quick test on macOS 
|
|
At least the new |
|
Ah, the My best guess is because the |
|
If I understand correctly, are the icons being sourced here? Pinta/Pinta.Resources/Pinta.Resources.csproj Lines 1 to 6 in bf6a3db There are some libadwaita apps have their We could either modify the source path for the icons or we could keep using the current |
In my mind we would use CSS variables to inject the colors into the SVGs, and change those variables at runtime (hopefully globally, and not per icon 😵💫), which I hope is possible independent of the file locations. Also, from a small test I did a while ago, icons without the |
What I meant is that not all icons will qualify for coloring, as explained here
I agree, hence the Anyway, I will move everything to |
|
I hope it's okay now! |
|
Thanks! The only issue I noticed is that the effects icon looks kinda small - I think this might be a similar issue to #2078 with GTK 4.22 so I can try making a similar fix 
edit: fixed! |
The nested and transformed groups seemed to be problematic and caused odd scaling issues.
|
It could be also because the menu icons are using a non-standard 24x24 resolution, but good to know of that GTK 4.22 bug! For the sake of uniformity, I will eventually convert all menu icons to a 16x16 resolution, especially if we go through with the File hamburger + menu bar: #1428 (comment) |
3 participants
As previously discussed in #1428 (comment), it would be good to eventually replace all custom icons with icons that follow the same Adwaita design language and guidelines, either by the official team or the community.
The
adjustments-brightnesscontrast-symbolic.svgcomes from Adwaita's icon library andeffects-default-symbolic.svgcomes from GIMP's icon repo and chosen for its ubiquity in the GNOME/FOSS community, as previously discussed (I double-checked the icon license and we're all clear).