Don't use deprecated FontButton#1421
Conversation
|
I'm not sure why the formatting is failing, even on lines I didn't change, like line 1 |
|
I'm not sure that the formatting issues are on the lines indicated by the log, but I know that formatting conventions are enforced relatively strictly. In the case of these changes, I think the problem comes from the new method calls If you are using Visual Studio, you could try following these steps and seeing if the problem is fixed:
|
cameronwhite
left a comment
cameronwhite
left a comment
There was a problem hiding this comment.
Yeah, I think the format check is failing from things like HandleFontChanged() which are missing the space before the parentheses. The output from dotnet format --verify-no-changes is always pretty cryptic for some reason ..
Running dotnet format from the command line should also work
|
|
||
| if (font_button == null) { | ||
| font_button = new Gtk.FontButton { | ||
| var fontDialog = new Gtk.FontDialog { |
There was a problem hiding this comment.
Minor suggestion for coding style - we prefer using Gtk.FontDialog fontDialog = new { ... };
There was a problem hiding this comment.
I used format selection, instead of format document, that's why I initially missed some cases 😅
|
The changes look good to me otherwise - thanks for working on this! BTW for future deprecation fixes, we are targeting a minimum of GTK 4.12 right now so that's something to be careful about checking. The FontDialogButton was added in 4.10 so this is fine |
Does it mean libadwaita 1.12? |
For libadwaita we're targeting a minimum of 1.4 (https://github.com/PintaProject/Pinta/blob/master/configure.ac#L50) |
|
For the fallback font, I tested on macOS and it selects |
|
On Windows it selected |
3 participants
No description provided.