Add keyboard shortcut for changing the brush size or line width#1155
Merged
Conversation
Member
cameronwhite
left a comment
cameronwhite
left a comment
There was a problem hiding this comment.
Thanks for looking at this!
The CI builds failed from some formatting issues - you should be able to just run dotnet format to fix those
For adding a tooltip, I think you should be able to set the TooltipText property on the spin button widget when it's created - this would be a tooltip for the whole widget, not individually for the +/- buttons.
For that string, you would also want to use Translations.GetString("...") so that it can be translated
Member
|
Looks good - thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements issue #796. The square brackets ] and [ increase and decrease the brush size respectively. Applies to all tools that implement BaseBrushTool and ShapeTool.
I'm wondering if it's possible to add a tooltip to the + and - buttons on the brush size widget? As of right now there's no indication that the shortcuts exist.