perf: drop redundant char* fixed in MessagePackWriter.Write(string)#2258
Open
unsafePtr wants to merge 1 commit into
Open
perf: drop redundant char* fixed in MessagePackWriter.Write(string)#2258unsafePtr wants to merge 1 commit into
unsafePtr wants to merge 1 commit into
Conversation
Author
|
@AArnott do I need to add any specific tests? Thought this change is straightforward |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On
SPAN_BUILTINtargets (netstandard2.1/net8.0/net9.0), use the span-basedEncoding.GetBytes(ReadOnlySpan<char>, Span<byte>)overload so thefixed (char* pValue = value)pin can go away. TheEncodingAPI pins the source itself for the duration of the encode, which is shorter than holding the pin acrossWriteString_PostEncoding.Legacy targets (
netstandard2.0/net472) keep the originalfixed (char* …)path under#else.The
fixed (byte* pBuffer = &buffer)stays for now —WriteString_PostEncodingstill takesbyte*and usesBuffer.MemoryCopyfor the overlapping prefix shift. Dropping that pin too would mean rewritingWriteString_PostEncodingtoref byte+MemoryMarshal.CreateSpan(...).CopyTo(...), butMemoryMarshal.CreateSpanisnetstandard2.1+only (not in theSystem.Memorybackport fornetstandard2.0/net472), so that's a bigger refactor for another PR.Test plan
netstandard2.0;netstandard2.1;net8.0;net9.0;net472)MessagePack.Tests— 999/999 pass onnet9.0, 968/968 onnet472