Skip to content

Bump FluentAssertions from 6.12.0 to 7.0.0#2114

Merged
AArnott merged 2 commits into
developfrom
dependabot/nuget/develop/FluentAssertions-7.0.0
Jan 6, 2025
Merged

Bump FluentAssertions from 6.12.0 to 7.0.0#2114
AArnott merged 2 commits into
developfrom
dependabot/nuget/develop/FluentAssertions-7.0.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jan 1, 2025

Copy link
Copy Markdown
Contributor

Bumps FluentAssertions from 6.12.0 to 7.0.0.

Release notes

Sourced from FluentAssertions's releases.

7.0.0

What's Changed

Breaking Changes

Fixes

Documentation

Others

New Contributors

Full Changelog: fluentassertions/fluentassertions@6.12.2...7.0.0

7.0.0-alpha.6

What's Changed

Breaking Changes

Fixes

Documentation

Others

... (truncated)

Commits
  • e0f4504 Added release note about raising dependencies
  • 5cdaa07 Downgrade ConfigurationManager from 6.0.1 to 6.0.0
  • ba3884e Update FluentAssertions package dependencies (#2673)
  • 4647b6f Missed two more references to master (#2849)
  • 483484d Changed references to the master branch to main (#2848)
  • 4ddd79f Fix minor syntax error in objectgraphs.md
  • 359d851 Fix building benchmarks project
  • b489c53 Fix support for write-only properties in BeEquivalentTo (#2836)
  • 5fa83e2 Drop support for .NET Core 2.1, 3.0 and NSpec (#2835)
  • 93efe19 Bump all relevant dependencies (#2834)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot Bot added the dependencies Pull requests that update a dependency file label Jan 1, 2025
@AArnott

AArnott commented Jan 5, 2025

Copy link
Copy Markdown
Collaborator

@neuecc I'm not sure how we validate this given the unity check fails for PRs. I'm hesitant to update things that impact tests since I think the test dependencies in particular may impact unity. Thoughts?

Bumps [FluentAssertions](https://github.com/fluentassertions/fluentassertions) from 6.12.0 to 7.0.0.
- [Release notes](https://github.com/fluentassertions/fluentassertions/releases)
- [Changelog](https://github.com/fluentassertions/fluentassertions/blob/develop/AcceptApiChanges.ps1)
- [Commits](fluentassertions/fluentassertions@6.12.0...7.0.0)

---
updated-dependencies:
- dependency-name: FluentAssertions
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot force-pushed the dependabot/nuget/develop/FluentAssertions-7.0.0 branch from 7ac1e29 to 8a06f9b Compare January 5, 2025 20:21
@neuecc

neuecc commented Jan 6, 2025

Copy link
Copy Markdown
Member

It's not about Unity tests, but the dotnet build is failing.
It seems that Source Generator generation isn't working in the tests (Instances are not being generated).
When I modified the Source Generator a bit last time, I encountered similar errors, and since the Source Generator test infrastructure is complex and would take time to understand, I temporarily worked around it by commenting out some tests. But now the issue has surfaced.

@neuecc

neuecc commented Jan 6, 2025

Copy link
Copy Markdown
Member

Could this be the cause?
The Microsoft.CodeAnalysis version is very sensitive, so careful consideration should be necessary...
#2115

@AArnott

AArnott commented Jan 6, 2025

Copy link
Copy Markdown
Collaborator

but the dotnet build is failing.

Oh! I totally missed that. 🤦🏻

Could this be the cause?
The Microsoft.CodeAnalysis version is very sensitive, so careful consideration should be necessary...
#2115

No, because that PR passed these validations and the CI after that is still passing:
https://github.com/MessagePack-CSharp/MessagePack-CSharp/actions/workflows/build-debug.yml?query=branch%3Adevelop

@AArnott

AArnott commented Jan 6, 2025

Copy link
Copy Markdown
Collaborator

Oh, I see this PR also changes the CodeAnalysis version. (Why does Dependabot do that??) Yes, that could be causing the problem. And it's usually undesirable to bump that version for the analyzer projects so we don't drop support for older VS versions unless we mean to.
If we manually revert that version bump, that may resolve the build break I guess.

BTW, in my own repos I recently switched from Dependabot to Renovate. It's more flexible and can do most of what Dependabot can do, and several things Dependabot can't.

@AArnott AArnott merged commit 8945bfe into develop Jan 6, 2025
@AArnott AArnott deleted the dependabot/nuget/develop/FluentAssertions-7.0.0 branch January 6, 2025 16:35
@neuecc

neuecc commented Jan 8, 2025

Copy link
Copy Markdown
Member

I see, the CodeAnalysis version has also been changed...!
Things often don't work well when conditions are involved.
Renovate looks good, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants