test(release_homebrew): Add session cleanup for homebrew fork repo#216
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #216 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 1604 1604
Branches 175 175
=========================================
Hits 1604 1604
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Introduce a session-scoped autouse fixture to remove the temporary homebrew_core_fork_repo after the test session. Add stat import and helper functions: _make_writable_and_retry to fix readonly files during removal, and _remove_test_repo which uses shutil.rmtree with the onexc handler. Move repo deletion out of the per-function fixture into the new session cleanup and compute the repo path from GITHUB_WORKSPACE.
ReenigneArcher
force-pushed
the
fix/release_homebrew/complete-todo
branch
from
2bed8f2 to
e450cfb
Compare
ReenigneArcher
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduce a session-scoped autouse fixture to remove the temporary homebrew_core_fork_repo after the test session. Add stat import and helper functions: _make_writable_and_retry to fix readonly files during removal, and _remove_test_repo which uses shutil.rmtree with the onexc handler. Move repo deletion out of the per-function fixture into the new session cleanup and compute the repo path from GITHUB_WORKSPACE.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage