test(release_homebrew): Handle read-only files when removing test repo

ReenigneArcher · ReenigneArcher · commit 2bed8f22e1de · 2026-06-01T11:10:13.000-04:00
Add logic to make files writable and retry removal to fix teardown failures. Imported stat and added _make_writable_and_retry (used as shutil.rmtree onexc handler) and _remove_test_repo which ensures cwd is reset and uses onexc to handle permission errors. The homebrew_core_fork_repo fixture teardown now calls _remove_test_repo instead of a plain shutil.rmtree to reliably delete the test repository.
diff --git a/tests/release_homebrew/conftest.py b/tests/release_homebrew/conftest.py
@@ -1,6 +1,7 @@
 # standard imports
 import os
 import shutil
+import stat
 import subprocess
 import sys
 
@@ -195,7 +196,18 @@ def org_homebrew_repo():
     yield repo_directory
 
 
-@pytest.fixture(scope='function')  # todo: fix repo deletion
+def _make_writable_and_retry(function, path, _exc_info):
+    os.chmod(path, os.stat(path).st_mode | stat.S_IWRITE)
+    function(path)
+
+
+def _remove_test_repo(repo_directory):
+    if os.path.isdir(repo_directory):
+        os.chdir(og_dir)
+        shutil.rmtree(repo_directory, onexc=_make_writable_and_retry)
+
+
+@pytest.fixture(scope='function')
 def homebrew_core_fork_repo():
     directory = os.path.join(os.environ['GITHUB_WORKSPACE'], 'release_homebrew_action')
     os.makedirs(directory, exist_ok=True)
@@ -234,8 +246,8 @@ def homebrew_core_fork_repo():
 
     yield repo_directory
 
-    # remove the homebrew-core fork (this fails)
-    # shutil.rmtree(repo_directory)
+    # remove the homebrew-core fork
+    _remove_test_repo(repo_directory)
 
 
 def _cleanup_bottle_files():
